Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_qa
-
Story Points:2
-
Epic Link:
-
Sprint:TSSW Sprint - May 13 - May 25, TSSW Sprint - May 28 - Jun 8
-
Team:Telescope and Site
Description
Add tests on ts_xml for <Unit> and <Description> fields, in accordance with https://confluence.lsstcorp.org/display/LTS/SAL+XML+Unit+Definition+-+Discussion. Also, add tests for XML Version; see VERSION file in the repo.
Attachments
Activity
Added tests for Attribute/Parameter Descriptions:
https://github.com/lsst-ts/robotframework_ts_xml/commit/52d5afa30ef1e9f5a5804b28bdbdea3cf8e383fb
While I have added these tests, I have not yet pushed them to the Jenkins build, as we still need to announce the changes and give people a chance to make the updates.
Here are the Unit test scripts:
https://github.com/lsst-ts/robotframework_ts_xml/blob/units_valid/Validate_Units.robot
https://github.com/lsst-ts/robotframework_ts_xml/blob/units_valid/scripts/Units.py
https://github.com/lsst-ts/robotframework_ts_xml/blob/units_valid/Unit_Validator.py
Here are the attribute description tests:
https://github.com/lsst-ts/robotframework_ts_xml/blob/units_valid/scripts/Attribute_Description.py
This work is currently in a branch;
https://github.com/lsst-ts/robotframework_ts_xml/tree/units_valid
And will be pushed to master once the new standard is announced and people have a chance to update their XMLs accordingly.
Code reviewed, awaiting to be merged and view the results of the tests. The scripts were ran locally by Rob, they run however many failures due to XML not being updated, XML to be updated by developers.
Task complete.
Added parameter Unit tests. See https://github.com/lsst-ts/robotframework_ts_xml/commit/a6eeea6c218e700ff8d052a7eb4849be14ac19be
And handling of dimensionless parameters:
https://github.com/lsst-ts/robotframework_ts_xml/commit/6f5306c95637e9f0e7d50b2100a25aed1bd991a9