Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1986

Add support for queries involving qserv_area_spec on non-partitioned tables

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      (by Daniel) qserv_areaspec_box asks qserv to choose chunk/row coverage according to the director table. Generally, it detects the director table from the query, computes the region against the index, and then substitutes the right directive. But in this case, there is no director table, only a child table. Hence, even if we know what the director table is, its columns are not available to use in the query, unless we rewrite to add an equi-join with the director table. The best we can do in this case (without adding a join), is to use the parameters for determining chunk coverage, and then covering all rows in those chunks. The user could specify additional conditions to apply spatial filtering based on other (non-partitioning) columns.

      Another thing we could do is to detect scisql region directives in the WHERE clause, but this expands the detection and dependence on scisql name/syntax (the first is in the angle distance condition when determining spatial join evaluability).

      Anyway, what I'm trying to say is that the right thing to do isn't completely clear, and the possible options are not that simple to implement (though the ones I've listed are certainly possible, and should be much easier than refmatch support).

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            I agree with Daniel's initial sentiment as expressed in DM-1985: if qserv_areaspec_box is specified to work only against Object (or other director table) ra/decl columns, then using it in a query where those columns are unavailable should be rejected. I think auto-including the director table with a join is more magic than is needed.

            Basically, ForcedSources don't contain ra/decl (or even x,y), so specifying a box for them is inappropriate.

            I would close this as Won't Fix.

            Show
            ktl Kian-Tat Lim added a comment - I agree with Daniel's initial sentiment as expressed in DM-1985 : if qserv_areaspec_box is specified to work only against Object (or other director table) ra/decl columns, then using it in a query where those columns are unavailable should be rejected. I think auto-including the director table with a join is more magic than is needed. Basically, ForcedSources don't contain ra/decl (or even x,y), so specifying a box for them is inappropriate. I would close this as Won't Fix.
            Hide
            jbecla Jacek Becla added a comment -

            There was a confusion, if table has ra/dec, then we should support it, even if it is slow. After talking to K-T, we agreed to reopen it.

            Show
            jbecla Jacek Becla added a comment - There was a confusion, if table has ra/dec, then we should support it, even if it is slow. After talking to K-T, we agreed to reopen it.
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            I believe this ticket is still relevant?

            I view it as a requirement at the ADQL level: whether we support geometry queries or not against tables in Qserv should not, to first order, depend on whether the tables are partitioned or not.

            But perhaps this ticket is not the right place to carry out any further debate?

            Show
            gpdf Gregory Dubois-Felsmann added a comment - I believe this ticket is still relevant? I view it as a requirement at the ADQL level: whether we support geometry queries or not against tables in Qserv should not, to first order, depend on whether the tables are partitioned or not. But perhaps this ticket is not the right place to carry out any further debate?
            Hide
            fritzm Fritz Mueller added a comment - - edited

            qserv_area_spec is deprecated.  The proposed/supported alternative, direct use of scisql_s2PtIn*, already works correctly for well-formulated queries on any sort of table.

            Show
            fritzm Fritz Mueller added a comment - - edited qserv_area_spec is deprecated.  The proposed/supported alternative, direct use of scisql_s2PtIn* , already works correctly for well-formulated queries on any sort of table.

              People

              Assignee:
              npease Nate Pease [X] (Inactive)
              Reporter:
              fritzm Fritz Mueller
              Watchers:
              Fritz Mueller, Gregory Dubois-Felsmann, Kian-Tat Lim, Tatiana Goldina, Vaikunth Thukral
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.