Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19871

Fix validity range end in Gen3 calibration bootstrapping

    Details

      Description

      The bootstrap scripts added on DM-19638 upgrade Gen2's dates to Gen3's datetimes without adding one day to the end dates.  Because those intervals are inclusive instead of half-open, that means we end up with a day-long gap between adjacent intervals.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Tim Jenness, mind taking a look at this one?  Changes are trivial, in obs_base and daf_butler.

          Show
          jbosch Jim Bosch added a comment - Tim Jenness , mind taking a look at this one?  Changes are trivial, in obs_base and daf_butler .
          Hide
          tjenness Tim Jenness added a comment -

          The code looks fine but I'm not sure I understand how we know that a day increment is the right thing. Is the point that we are assuming that the gen2 repo is all set up correctly and uses full days, so this change must be correct?

          Show
          tjenness Tim Jenness added a comment - The code looks fine but I'm not sure I understand how we know that a day increment is the right thing. Is the point that we are assuming that the gen2 repo is all set up correctly and uses full days, so this change must be correct?
          Hide
          jbosch Jim Bosch added a comment -

          Yes, that was exactly my assumption.  I think it's got to be valid for HSC, since otherwise the dark lookup that triggered this issue wouldn't work in Gen2 either, but I'm not sure if it's safe to assume that all other obs packages use full days in their calibration repos.

           

          Show
          jbosch Jim Bosch added a comment - Yes, that was exactly my assumption.  I think it's got to be valid for HSC, since otherwise the dark lookup that triggered this issue wouldn't work in Gen2 either, but I'm not sure if it's safe to assume that all other obs packages use full days in their calibration repos.  
          Hide
          tjenness Tim Jenness added a comment -

          obs_lsst won't be using full days, but then again I think Robert Lupton is hoping that by the time we get there we are not using gen 2 any more.

          Show
          tjenness Tim Jenness added a comment - obs_lsst won't be using full days, but then again I think Robert Lupton is hoping that by the time we get there we are not using gen 2 any more.
          Hide
          jbosch Jim Bosch added a comment -

          And if we are, this won't be the only challenge in making gen2convert work on a second instrument - there are currently a lot of HSC-isms in there, because I didn't have (and still don't have) a great sense for what can be counted on to be consistent across obs packages in Gen2 calibrations.

          Show
          jbosch Jim Bosch added a comment - And if we are, this won't be the only challenge in making gen2convert work on a second instrument - there are currently a lot of HSC-isms in there, because I didn't have (and still don't have) a great sense for what can be counted on to be consistent across obs packages in Gen2 calibrations.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Tim Jenness
              Watchers:
              Jim Bosch, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel