Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19873

Implement PropertySet.getitem and return get()

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: daf_base
    • Labels:
      None

      Description

      Following the adoption of RFC-596:

      • Add getitem support (returning scalars in all cases)
      • Undeprecate get(), modifying it to return scalars and to support a default value.
      • Investigate adding update() method.

        Attachments

          Issue Links

          has to be done after

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19877 Replace PropertySet.get with getScalar or getArray

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-596 Add getitem to PropertySet and PropertyList

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21363 Fix semantics of PropertySet.update

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Russell Owen the PR implements RFC-596: getitem and get now call getScalar. Also added update() method to match dict (although I haven't added support for kwargs). This PR requires that DM-19877 is merged first.

            Show
            tjenness Tim Jenness added a comment - Russell Owen the PR implements RFC-596 : getitem and get now call getScalar. Also added update() method to match dict (although I haven't added support for kwargs). This PR requires that DM-19877 is merged first.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Overall looks great. A few comments on github

            Show
            rowen Russell Owen added a comment - Overall looks great. A few comments on github
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thanks for your review. Merged.

            Show
            tjenness Tim Jenness added a comment - Thanks for your review. Merged.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Russell Owen
              Watchers:
              Kian-Tat Lim, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.