Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19877

Replace PropertySet.get with getScalar or getArray

    XMLWordPrintable

    Details

      Description

      DM-19873 is changing the API of PropertySet.get() such that it will now return a default value rather than raising KeyError. Before that can happen, all extant calls to get() must be replaced to avoid any surprises.

      The approach I will take is to change get() so that it always throws an exception and then wait for tests to fail. This may lead to some remaining usage of get() in code that is not used.

        Attachments

          Issue Links

          has to be done before

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19873 Implement PropertySet.getitem and return get()

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Russell Owen I only needed to fix three packages. Would you mind doing a quick review?

            Show
            tjenness Tim Jenness added a comment - Russell Owen I only needed to fix three packages. Would you mind doing a quick review?
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Looks great and a nice simplification in the case of using getArray.

            Show
            rowen Russell Owen added a comment - Looks great and a nice simplification in the case of using getArray.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Russell Owen
              Watchers:
              Kian-Tat Lim, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.