Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1988

Update analysis tasks: diffim and snap combination

    XMLWordPrintable

    Details

    • Epic Name:
      Update analysis tasks: diffim and snap combination
    • Story Points:
      43
    • WBS:
      02C.03.04
    • Team:
      Alert Production
    • Cycle:
      Fall 2016

      Description

      50% KSK 50% RO A small amount of this work is in 02C.03.01
      The diffim task needs to be looked at. It needs to be updated to use current mechanisms. It should also be refactored to split out some of the procedural code into methods.

      In a similar task, the lsstSimIsrTask needs to include a real snap combine step. Currently, one of the snaps is dropped on the floor. For this round just implement naive snap addition and morphological CR rejection.

        Attachments

        Stories in Epic (Custom Issue Matrix)

        Key Summary Story Points Assignee Status
         
        		DM-3213

        Get ImageDifferenceTask running again

        		10 Yusra AlSayyad Done
         
        		DM-3515

        Refactor DipoleMeasurement: Dipole classification to plugin

        		6 Yusra AlSayyad Done

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          While looking at DM-980 (converting ip_diffim to use meas_base), I ran across some suspicious looking code in src/DipoleAlgorithm.cc. Specifically, in NaiveDipoleFootprinter:

          184         if (ival >= 0.0) {
          		 
          185             _sumPositive += ival;
          		 
          186             _varPositive += vval;
          		 
          187             ++_numPositive;
          		 
          188         } else {
          		 
          189             _sumNegative += ival;
          		 
          190             _varPositive += vval;

          Should be _varNegative?

          195     double getSumPositive() const { return _sumPositive; }
          		 
          196     double getSumNegative() const { return _sumNegative; }
          		 
          197     double getVarPositive() const { return _sumPositive; }
          		 
          198     double getVarNegative() const { return _sumNegative; }

          Surely the last two should return _varPositive and _varNegative respectively?

          202 private:
          		 
          203     double _sumPositive;
          		 
          204     double _sumNegative;
          		 
          205     double _varPositive;
          		 
          206     double _varNegative;

          _varNegative is never used.

          I've not attempted to understand the algorithm, so the above could all be intentional (but strange); furthermore, it may be this code will all be scrapped and replaced as part of this epic. However, I wanted to record these issues somewhere to make sure they aren't forgotten.

          Show
          swinbank John Swinbank added a comment - While looking at DM-980 (converting ip_diffim to use meas_base ), I ran across some suspicious looking code in src/DipoleAlgorithm.cc . Specifically, in NaiveDipoleFootprinter : 184 if (ival >= 0.0) { 185 _sumPositive += ival; 186 _varPositive += vval; 187 ++_numPositive; 188 } else { 189 _sumNegative += ival; 190 _varPositive += vval; Should be _varNegative ? 195 double getSumPositive() const { return _sumPositive; } 196 double getSumNegative() const { return _sumNegative; } 197 double getVarPositive() const { return _sumPositive; } 198 double getVarNegative() const { return _sumNegative; } Surely the last two should return _varPositive and _varNegative respectively? 202 private : 203 double _sumPositive; 204 double _sumNegative; 205 double _varPositive; 206 double _varNegative; _varNegative is never used. I've not attempted to understand the algorithm, so the above could all be intentional (but strange); furthermore, it may be this code will all be scrapped and replaced as part of this epic. However, I wanted to record these issues somewhere to make sure they aren't forgotten.
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Finishing the work involved in refactoring will be undertaken DM-14450.

          Show
          swinbank John Swinbank added a comment - Finishing the work involved in refactoring will be undertaken DM-14450 .

            People

            Assignee:
            krughoff Simon Krughoff
            Reporter:
            krughoff Simon Krughoff
            Watchers:
            John Swinbank, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Summary Panel