Details
-
Type:
Epic
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_diffim, pipe_tasks
-
Labels:
-
Epic Name:Update analysis tasks: diffim and snap combination
-
Story Points:43
-
WBS:02C.03.04
-
Team:Alert Production
-
Cycle:Fall 2016
Description
50% KSK 50% RO A small amount of this work is in 02C.03.01
The diffim task needs to be looked at. It needs to be updated to use current mechanisms. It should also be refactored to split out some of the procedural code into methods.
In a similar task, the lsstSimIsrTask needs to include a real snap combine step. Currently, one of the snaps is dropped on the floor. For this round just implement naive snap addition and morphological CR rejection.
Attachments
Key | Summary | Story Points | Assignee | Status | |
---|---|---|---|---|---|
|
|
6 | Yusra AlSayyad | Done | |
|
|
10 | Yusra AlSayyad | Done |
While looking at
DM-980(converting ip_diffim to use meas_base), I ran across some suspicious looking code in src/DipoleAlgorithm.cc. Specifically, in NaiveDipoleFootprinter:185 _sumPositive += ival;
186 _varPositive += vval;
187 ++_numPositive;
189 _sumNegative += ival;
190 _varPositive += vval;
Should be _varNegative?
Surely the last two should return _varPositive and _varNegative respectively?
_varNegative is never used.
I've not attempted to understand the algorithm, so the above could all be intentional (but strange); furthermore, it may be this code will all be scrapped and replaced as part of this epic. However, I wanted to record these issues somewhere to make sure they aren't forgotten.