Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19901

Improve __eq__ for Defects object

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None

      Description

      See discussion on DM-19891 for what wants doing. Should be quick and easy, but desired behaviour needs to be decided on beforehand. The options are:

      • Create a set with the coordinates of each box in a tuple (Box2I can't be stored in a set) and compare sets.
      • Create a masked image and compare masks.

      The former does not allow for case where in one Defects list a box is split into two and in the other it is a single box.

        Attachments

          Issue Links

            Activity

            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Perhaps Simon Krughoff and/or Christopher Waters could comment on whether having a defect split into to contiguous regions makes any difference anywhere, as I think this is what determines equivalence in the most practical sense.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Perhaps Simon Krughoff and/or Christopher Waters could comment on whether having a defect split into to contiguous regions makes any difference anywhere, as I think this is what determines equivalence in the most practical sense.
            Hide
            czw Christopher Waters added a comment -

            ISR only operates on the union of the defect regions, so the mask equivalence should be fine for that purpose.

            Show
            czw Christopher Waters added a comment - ISR only operates on the union of the defect regions, so the mask equivalence should be fine for that purpose.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Great, thanks!

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Great, thanks!

              People

              • Assignee:
                Unassigned
                Reporter:
                mfisherlevine Merlin Fisher-Levine
                Watchers:
                Christopher Waters, Merlin Fisher-Levine
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel