Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-19912

Rename fluxMin and fluxMax in various star/source selector configs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In an ap_pipe config file, the following flux min and max values are set. (I have listed only the min values for brevity, but each one has a corresponding max.) They should all be renamed to instFluxMin or instFluxMax as appropriate.

      As a side note, the default for all the fluxMins listed below is 12500 and the default for all the corresponding fluxMaxs is 0 (i.e., ignored). I am not sure where this is set or if it is still a good choice for all the fluxMins.
       

      config.ccdProcessor.charImage.measureApCorr.sourceSelector['objectSize'].fluxMin
      		 
      config.ccdProcessor.charImage.ref_match.sourceSelector['objectSize'].fluxMin
      		 
      config.ccdProcessor.charImage.measurePsf.starSelector['objectSize'].fluxMin
      		 
      config.ccdProcessor.calibrate.astrometry.sourceSelector['objectSize'].fluxMin
      		 
      config.differencer.astrometer.sourceSelector['objectSize'].fluxMin
      		 
      config.differencer.sourceSelector.fluxMin

        Attachments

          Activity

          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          They are set here:
          https://github.com/lsst/meas_algorithms/blob/master/python/lsst/meas/algorithms/objectSizeStarSelector.py#L46-L57

          I would argue that 12500 is way too high (for regular single frame processing...not sure for ap_pipe) but, even better, would be to select on S/N. I put some comments and motivating plots on DM-17043 if you're interested.

          Show
          lauren Lauren MacArthur added a comment - They are set here: https://github.com/lsst/meas_algorithms/blob/master/python/lsst/meas/algorithms/objectSizeStarSelector.py#L46-L57 I would argue that 12500 is way too high (for regular single frame processing...not sure for ap_pipe ) but, even better, would be to select on S/N. I put some comments and motivating plots on DM-17043 if you're interested.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            mrawls Meredith Rawls
            Watchers:
            John Parejko, Lauren MacArthur, Meredith Rawls
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:

                Jenkins

                No builds found.