Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20042

ATDome should wait until shutter commands are finished before acknowledging the command as complete

    Details

      Description

      Update ts_ATDome to wait until shutter open/close commands are finished before acknowledging the command as complete.

      Don't do this for azimuth moves because such moves may be superseded in normal operation.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Tiago Ribeiro what do you think we should do if the CSC is taken out of the enabled state while a louver command is running? Basically we can allow the current motion to finish or halt motion in all axes (unfortunately we cannot halt only azimuth, which would be my first choice, because the vendor's software does not support that). I slightly lean towards halting motion, but worry that one might be trying to close louvers due to impending rain. Not that it's normal to take ATDome out of enabled while trying to close louvers, but perhaps if folks were in a panic...

            I assume i should return SAL__CMD_ABORTED = -303 if a louver command is interrupted, whether by a new command superseding the old one or going OFFLINE or...

            Show
            rowen Russell Owen added a comment - Tiago Ribeiro what do you think we should do if the CSC is taken out of the enabled state while a louver command is running? Basically we can allow the current motion to finish or halt motion in all axes (unfortunately we cannot halt only azimuth, which would be my first choice, because the vendor's software does not support that). I slightly lean towards halting motion, but worry that one might be trying to close louvers due to impending rain. Not that it's normal to take ATDome out of enabled while trying to close louvers, but perhaps if folks were in a panic... I assume i should return SAL__CMD_ABORTED = -303 if a louver command is interrupted, whether by a new command superseding the old one or going OFFLINE or...
            Hide
            tribeiro Tiago Ribeiro added a comment -

            Russell Owen and I spoke about this in person during the PCW.

            Show
            tribeiro Tiago Ribeiro added a comment - Russell Owen and I spoke about this in person during the PCW.
            Hide
            rowen Russell Owen added a comment - - edited

            We agreed that it would be best if the CSC sends these two commands to the low level controller whenever the CSC it is disabled:

            • stop all motion (to stop the azimuth)
            • close the louvers (in case of rain)

            The CSC will send these commands, wait for acknowledgement and then go into a disabled state. It will not wait for the commands to finish.

            Show
            rowen Russell Owen added a comment - - edited We agreed that it would be best if the CSC sends these two commands to the low level controller whenever the CSC it is disabled: stop all motion (to stop the azimuth) close the louvers (in case of rain) The CSC will send these commands, wait for acknowledgement and then go into a disabled state. It will not wait for the commands to finish.
            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - ts_ATDome pull request: https://github.com/lsst-ts/ts_ATDome/pull/11
            Hide
            cwinslow Colin Winslow added a comment -

            Looks good to me. I'm getting a few test failures, but they're related to me not having Sal 4 / Salobj 5 yet. I'll also be cribbing a bit from these streamlined async unit tests. A big improvement. 

            Show
            cwinslow Colin Winslow added a comment - Looks good to me. I'm getting a few test failures, but they're related to me not having Sal 4 / Salobj 5 yet. I'll also be cribbing a bit from these streamlined async unit tests. A big improvement. 
            Hide
            jbuffill James Buffill [X] (Inactive) added a comment -

            Done

            Show
            jbuffill James Buffill [X] (Inactive) added a comment - Done
            Hide
            rowen Russell Owen added a comment -

            It would really help me to leave this open until I can merge it. Otherwise I am afraid I'll lose track of it. Merging is blocked on salobj v5 which is blocked on SAL 4.

            Show
            rowen Russell Owen added a comment - It would really help me to leave this open until I can merge it. Otherwise I am afraid I'll lose track of it. Merging is blocked on salobj v5 which is blocked on SAL 4.
            Hide
            rowen Russell Owen added a comment - - edited

            Merged to develop. I will release after salobj 5 (which is waiting for SAL 4) using DM-21366

            Show
            rowen Russell Owen added a comment - - edited Merged to develop. I will release after salobj 5 (which is waiting for SAL 4) using DM-21366

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Colin Winslow
                Watchers:
                Colin Winslow, James Buffill [X] (Inactive), Russell Owen, Tiago Ribeiro
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: