Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20073

Add ability to construct ObservationInfo from kwargs (or allow properties to be changed)

    Details

      Description

      Currently an ObservationInfo can only be constructed from the metadata of an observation. There are some cases where it would be useful to create an ObservationInfo from either kwargs or else update values in an ObservationInfo after creation (currently they are immutable).

      DM-19978 would be simplified if an ObservationInfo could be constructed from known values.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Ian Sullivan does this do what you need? It was a bit more work then I expected because I ended up adding type validation to make sure that when I require a Quantity I'm given a Quantity (albeit not checking that the quantity has the right units)

            Show
            tjenness Tim Jenness added a comment - Ian Sullivan does this do what you need? It was a bit more work then I expected because I ended up adding type validation to make sure that when I require a Quantity I'm given a Quantity (albeit not checking that the quantity has the right units)
            Hide
            sullivan Ian Sullivan added a comment -

            This greatly simplifies the process of constructing a visitInfo from scratch, and removes code duplication from DM-19978 where quantities otherwise had to be recalculated.

            Show
            sullivan Ian Sullivan added a comment - This greatly simplifies the process of constructing a visitInfo from scratch, and removes code duplication from DM-19978 where quantities otherwise had to be recalculated.
            Hide
            tjenness Tim Jenness added a comment -

            Merged. Thanks for the review.

            Show
            tjenness Tim Jenness added a comment - Merged. Thanks for the review.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Ian Sullivan
                Watchers:
                Ian Sullivan, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: