Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20129

Create unit tests for meas_extensions_scarlet

    XMLWordPrintable

    Details

    • Story Points:
      5
    • Epic Link:
    • Sprint:
      DRP F19-1, DRP F19-2
    • Team:
      Data Release Production

      Description

      Currently there are no unit tests for mea_extensions_scarlet. Tests should be implemented to ensure that changes in the stack do not break this package.

        Attachments

          Issue Links

          is triggering

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-606 Add meas_extensions_scarlet to lsst_distrib

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Nate Lust do you mind reviewing this ticket? All of the scarlet changes have been reviewed in other tickets, this branch just pulls the changes from the main scarlet repo (per Tim Jenness the ticket branch on lsst/scarlet only exists so that we can execute a Jenkins run. The lsst_dev branch will be merged directly from master, so there is no need to make a PR on github). So it is only meas_extensions_scarlet that needs to be reviewed.

            Show
            fred3m Fred Moolekamp added a comment - Nate Lust do you mind reviewing this ticket? All of the scarlet changes have been reviewed in other tickets, this branch just pulls the changes from the main scarlet repo (per Tim Jenness the ticket branch on lsst/scarlet only exists so that we can execute a Jenkins run. The lsst_dev branch will be merged directly from master, so there is no need to make a PR on github). So it is only meas_extensions_scarlet that needs to be reviewed.
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Jenkins tests pass: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30077/pipeline

            Show
            fred3m Fred Moolekamp added a comment - Jenkins tests pass: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30077/pipeline
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Few questions/comments, overall looks fine

            Show
            nlust Nate Lust added a comment - Few questions/comments, overall looks fine

              People

              Assignee:
              fred3m Fred Moolekamp
              Reporter:
              fred3m Fred Moolekamp
              Reviewers:
              Nate Lust
              Watchers:
              Fred Moolekamp, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: