Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20154

Implement new initial WCS design

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Epic Link:
    • Sprint:
      AP S19-6, AP F19-1, AP F19-2
    • Team:
      Alert Production

      Description

      The close of DM-19951 describes a new design for how we create an initial WCS from the raw exposure VisitInfo metadata. This ticket is to implement that design. In summary:

      • Write tests against sensor bounding boxes on known data (e.g. testdata_*).
      • Write a new function to create a SkyWcs from VisitInfo and Detector (createInitialSkyWcs?).
      • Call that function from exposureFromImage.
      • Reorder the reading of raw VisitInfo and WCS metadata to deal potential metadata stripping problems.
      • Check that all existing cameras use this code path, and not some custom Exposure metadata handling.
      • Turn off addDistortionModel in ISR for all cameras, so that the above WCS does not get overwritten.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20201 Fix DECam rotator type and angle in metadata translator

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20202 Fix CFHT MegaPrime rotator type and angle in metadata translator

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20373 Move FitsRawFormatterBase from daf_butler into obs_base

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20548 Update HSC's camera geometry to use units of millimeters

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-19951 Write down astrometry model

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-616 New approach to the WCS of raw exposures

          • Implemented
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20378 System for deprecating Config fields

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-20499 Add basic stringification to SkyWcs

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-21248 cameraMapper _standardizeExposure should not try to create a WCS for each amp

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20746 Add camera orientation parity to camera geometry

          • In Progress

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20188 Try out cameraGeom+boresight+rotation approach to initial WCSs

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20937 Add deprecation warnings for to-be-removed distorted WCS functions

          • Done

            Activity

            Ascending order - Click to sort in descending order
            10 older comments
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            After lots of fun discussions about docstring inheritance, CRVAL being the actual worst, deprecation warnings, etc., I'm marking this as reviewed pending an ap_verify run on the CI dataset demonstrating the metrics that do not wildly differ from a recent ap_verify actual-CI run. Let me know if you want help with that!

            Show
            mrawls Meredith Rawls added a comment - After lots of fun discussions about docstring inheritance, CRVAL being the actual worst, deprecation warnings, etc., I'm marking this as reviewed pending an ap_verify run on the CI dataset demonstrating the metrics that do not wildly differ from a recent ap_verify actual-CI run. Let me know if you want help with that!
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            I ran ap_verify on ap_verify_ci_hits2015, and the output seems to match that of past runs (looking at the dashboard and one run against master, I get 1706 unassociated sources), so I think we're ok there.

            I'm still blocked on DM-20548, but otherwise I think we're ok to merge.

            Show
            Parejkoj John Parejko added a comment - - edited I ran ap_verify on ap_verify_ci_hits2015 , and the output seems to match that of past runs (looking at the dashboard and one run against master, I get 1706 unassociated sources), so I think we're ok there. I'm still blocked on DM-20548 , but otherwise I think we're ok to merge.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Post-rebase Jenkins run:
            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30312/pipeline

            Show
            Parejkoj John Parejko added a comment - Post-rebase Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30312/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            After rebasing, ap_verify_ci_hits2015 still produces the same metric, so we're still ok there. DM-20548 is merged, so once the above Jenkins run completes successfully, I'll finally merge this.

            Show
            Parejkoj John Parejko added a comment - After rebasing, ap_verify_ci_hits2015 still produces the same metric, so we're still ok there. DM-20548 is merged, so once the above Jenkins run completes successfully, I'll finally merge this.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for all the review comments and testing suggestions Meredith Rawls.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thanks for all the review comments and testing suggestions Meredith Rawls . Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Meredith Rawls
              Watchers:
              Chris Morrison, Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.