Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_base
-
Labels:
-
Story Points:8
-
Epic Link:
-
Sprint:AP S19-6, AP F19-1, AP F19-2
-
Team:Alert Production
Description
The close of DM-19951 describes a new design for how we create an initial WCS from the raw exposure VisitInfo metadata. This ticket is to implement that design. In summary:
- Write tests against sensor bounding boxes on known data (e.g. testdata_*).
- Write a new function to create a SkyWcs from VisitInfo and Detector (createInitialSkyWcs?).
- Call that function from exposureFromImage.
- Reorder the reading of raw VisitInfo and WCS metadata to deal potential metadata stripping problems.
- Check that all existing cameras use this code path, and not some custom Exposure metadata handling.
- Turn off addDistortionModel in ISR for all cameras, so that the above WCS does not get overwritten.
Attachments
Issue Links
- is blocked by
-
- Done
-
- Done
-
- Done
-
- Done
- is triggered by
-
- Done
-
- Implemented
- is triggering
-
- Done
-
DM-20499 Add basic stringification to SkyWcs
- Done
- relates to
-
DM-21248 cameraMapper _standardizeExposure should not try to create a WCS for each amp
- Done
-
- In Progress
-
- Done
-
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | DM-19943 [ 306001 ] |
| Component/s | obs_base [ 10719 ] | |
| Sprint | AP S19-6 [ 834 ] | |
| Story Points | 8 | |
| Team | Alert Production [ 10300 ] | |
| Assignee | John Parejko [ parejkoj ] | |
| Description |
The close of * Write tests against sensor bounding boxes on known data (e.g. {{testdata_*}}). * Write a new function to create a SkyWcs from VisitInfo and Detector ({{createInitialSkyWcs}}?). * Call that function from {{exposureFromImage}}. * Reorder the reading of raw VisitInfo and WCS metadata to deal potential metadata stripping problems. * Check that all existing cameras use this code path, and not some custom Exposure metadata handling. * Turn off {{addDistortionModel}} in ISR for all cameras, so that the above WCS does not get overwritten. |
|
| Labels | SciencePipelines | |
| Summary | obs_base | Implement new initial WCS design |
| Watchers | John Parejko [ John Parejko ] | Chris Morrison, Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur [ Chris Morrison, Jim Bosch, John Parejko, John Swinbank, Lauren MacArthur ] |
| Sprint | AP S19-6 [ 834 ] | AP S19-6, AP F19-1 [ 834, 923 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Jim Bosch [ jbosch ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Reviewers | Jim Bosch [ jbosch ] | Meredith Rawls [ mrawls ] |
| Status | In Review [ 10004 ] | In Progress [ 3 ] |
| Sprint | AP S19-6, AP F19-1 [ 834, 923 ] | AP S19-6, AP F19-1, AP F19-2 [ 834, 923, 940 ] |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |