Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20235

base_PixelFlags_flag is not being set

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      When we look at the various pixel flags on processed images, we expect the base_PixelFlags_flag to be set when any of the individual pixel flags (edge, bad, interpolated, suspect, etc.) are set. Instead, it is never set. This should be fixed.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          base_PixelFlags_flag gets set if there's an error in running the plugin. It is not intended to be an OR of all the components.

          Show
          price Paul Price added a comment - base_PixelFlags_flag gets set if there's an error in running the plugin. It is not intended to be an OR of all the components.
          Hide
          mrawls Meredith Rawls added a comment -

          Hm, ok, that's counter to how some of the other flags I've seen work (e.g., slot_Shape_flag appears to be an OR of all the various flavors of shape flags). I think we should be consistent, and Yusra and Eric also assumed this was a bug. But perhaps this discussion is verging into RFC territory... 

          Show
          mrawls Meredith Rawls added a comment - Hm, ok, that's counter to how some of the other flags I've seen work (e.g., slot_Shape_flag appears to be an OR of all the various flavors of shape flags). I think we should be consistent, and Yusra and Eric also assumed this was a bug. But perhaps this discussion is verging into RFC territory... 
          Hide
          swinbank John Swinbank added a comment -

          This is a little confusing, but it's not clear how to make it less so within the constraints of the measurement framework we are using. As it stands now, I tend to agree with Paul Price that the code is doing the right thing.

          Given that, I propose to close this ticket as “Won't Fix”, and invite Meredith Rawls (or anybody else) to file an RFC proposing a specific change if they can suggest something which they feel would be more straightforward.

          Show
          swinbank John Swinbank added a comment - This is a little confusing, but it's not clear how to make it less so within the constraints of the measurement framework we are using. As it stands now, I tend to agree with Paul Price that the code is doing the right thing. Given that, I propose to close this ticket as “Won't Fix”, and invite Meredith Rawls (or anybody else) to file an RFC proposing a specific change if they can suggest something which they feel would be more straightforward.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            mrawls Meredith Rawls
            Watchers:
            Eric Bellm, John Swinbank, Meredith Rawls, Paul Price, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.