Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20268

Update dev guide to reflect that we can use the "Big Green Button" on github

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Team:
      Architecture

      Description

      The section in the developer guide about Merging still discourages devs from using the "big green button" on github. That's out of date now: it's probably better to use it, because you'll be sure that you're rebased against master and travis completed. I don't know that we have any repositories for which it's not safe to use: if so, we could either document them, or list the conditions under which we shouldn't use it.

      Please update that paragraph to reflect this.

        Attachments

          Activity

          Hide
          ktl Kian-Tat Lim added a comment -

          I think the ultimate solution to this is going to be an automated repo checker that ensures that the appropriate branch protection and Travis checks are enabled, at which point we can be confident that the green button will always work.  I believe the GitHub API has methods for this.

          Show
          ktl Kian-Tat Lim added a comment - I think the ultimate solution to this is going to be an automated repo checker that ensures that the appropriate branch protection and Travis checks are enabled, at which point we can be confident that the green button will always work.  I believe the GitHub API has methods for this.
          Hide
          Parejkoj John Parejko added a comment -

          Given the recent problem of no tests being run for DM-23490, and it not being merged properly (relevant here), can we please get the dev guide updated to reflect the above?

          Show
          Parejkoj John Parejko added a comment - Given the recent problem of no tests being run for DM-23490 , and it not being merged properly (relevant here), can we please get the dev guide updated to reflect the above?

            People

            Assignee:
            ktl Kian-Tat Lim
            Reporter:
            Parejkoj John Parejko
            Watchers:
            John Parejko, John Swinbank, Kian-Tat Lim, Simon Krughoff, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated: