Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20287

Fix logging in IsrTask

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      DRP F19-1, DRP F19-2
    • Team:
      Data Release Production

      Description

      I found log messages from ISR saying:

      processCcd.isr INFO: Applying brighter fatter correction.
      processCcd.isr INFO: Finished brighter fatter correction in {bfResults[1]} iterations.
      

      This incorrectly uses the new python string formatting (missing a leading f on the string). However, we generally want log messages to defer the formatting, so the old %f style should be used instead.

      I suggest auditing other recent changes to the logging for similar bugs.

        Attachments

          Activity

          Hide
          price Paul Price added a comment -

          Reviewed on GitHub. Looks good, thanks!

          Show
          price Paul Price added a comment - Reviewed on GitHub. Looks good, thanks!

            People

            Assignee:
            czw Christopher Waters
            Reporter:
            price Paul Price
            Reviewers:
            Paul Price
            Watchers:
            Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.