Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_lsst
-
Labels:None
-
Story Points:1
-
Team:External
Description
1. Add deepDiff_diaObject datasetType
– This is still a bit experimental. It's being used and tested through DESC DC2 and dia_pipe, so it seems appropriate to just include these datasetTypes here in obs_lsst and not propagate to obs_base.
2. Correct deepDiff_diaSrc datasetType templates to use %08d to format visit.
Original work done by Bob Armstrong.
Michael Wood-Vasey 's work is to do some light reformatting and testing.
Attachments
Issue Links
- relates to
-
DM-14325 deepDiff datasets not supported by HSC
- Done
Activity
Hi Michael Wood-Vasey — sorry for being slow getting back to you.
Yusra AlSayyad, Colin Slater, Jim Bosch, Robert Lupton, Leanne Guy, Zeljko Ivezic and I (phew) discussed this today. We are happy for you to go ahead and merge this to obs_lsst (not obs_base), on the understanding that:
- this is a temporary expedient, which will likely be rendered obsolete by the upcoming Gen 3 migration (and/or just replaced by later developments on the DM side);
- DM won't be responsible for fixing things that are broken by DM-side development which touches this part of the codebase.
Michael should answer himself, but with my DESC DM DRP hat on, that sounds reasonable. For DESC, we are intending to use v18.1.0 for our next phase of DC2 and hope to put in a request to backport this specific update. That should be enough for our purposes, until we are ready to move ahead to Gen 3 with the upcoming v19 release.
Heather Kelly
added a comment - Michael should answer himself, but with my DESC DM DRP hat on, that sounds reasonable. For DESC, we are intending to use v18.1.0 for our next phase of DC2 and hope to put in a request to backport this specific update. That should be enough for our purposes, until we are ready to move ahead to Gen 3 with the upcoming v19 release. Ok, that sounds good. Thank you.
Michael Wood-Vasey
added a comment - Ok, that sounds good. Thank you. Rebased to latest origin/master. Passes Jenkins.
Merged to master.
Michael Wood-Vasey
added a comment - - edited Rebased to latest origin/master . Passes Jenkins.
Merged to master. 
John Swinbank It would be substantially helpful to DESC to merge in this update, and I would suggest does represent progress for Project, even taking into account the concern above. What path forward do you suggest?
For completeness, I've re-based and re-run Jenkins against the latest obs_lsst (and everything else) master:
https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30549/pipeline