Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20566

Remove aliased afwGeom geom usage from stack

    XMLWordPrintable

Details

    • 6
    • Arch 2019-07-15, Arch 2019-07-22
    • Architecture

    Description

      We have deprecated lsst.afw.geom.Point2I and related routines but they are still used all over the place. They need to be removed so that to allow DM-20565 to be unblocked.

      Attachments

        Issue Links

          Activity

            Parejkoj John Parejko added a comment -

            It looks like your C++ modifications include a clang-format pass? Might be good to do a single clang-format on the src and include directories first, before you modify anything, as not everyone runs it on save, so small C++ often also include other formatting changes because of that.

            I've done these:

            meas_extensions_shapeHSM
            coadd_utils
            obs_base
            obs_test
            shapelet

            Parejkoj John Parejko added a comment - It looks like your C++ modifications include a clang-format pass? Might be good to do a single clang-format on the src and include directories first, before you modify anything, as not everyone runs it on save, so small C++ often also include other formatting changes because of that. I've done these: meas_extensions_shapeHSM coadd_utils obs_base obs_test shapelet
            tjenness Tim Jenness added a comment -

            Thanks. Actually, my editor strips trailing whitespace automatically and I didn't notice it do that. I'll see if I can split the commits up.

            tjenness Tim Jenness added a comment - Thanks. Actually, my editor strips trailing whitespace automatically and I didn't notice it do that. I'll see if I can split the commits up.

            Tim, it looks like you're actually doing this work, so I'm assigning the ticket to you!

            swinbank John Swinbank added a comment - Tim, it looks like you're actually doing this work, so I'm assigning the ticket to you!
            tjenness Tim Jenness added a comment -

            I'm trying to stop doing it...

            tjenness Tim Jenness added a comment - I'm trying to stop doing it...
            tjenness Tim Jenness added a comment - - edited

            I merged meas_extensions_psfex.

            Currently ready for review:

            • meas_modelfit
            • obs_cfht
            • meas_extensions_simpleShape
            • meas_extensions_photometryKron

            meas_modelfit needed a bit more work than usual because the tests needed some clean up and one of the test files had been disabled by mistake for 2 years because it was renamed and lost its .py extension.

            tjenness Tim Jenness added a comment - - edited I merged meas_extensions_psfex. Currently ready for review: meas_modelfit obs_cfht meas_extensions_simpleShape meas_extensions_photometryKron meas_modelfit needed a bit more work than usual because the tests needed some clean up and one of the test files had been disabled by mistake for 2 years because it was renamed and lost its .py extension.
            tjenness Tim Jenness added a comment -

            More ready for review:

            • pipe_tasks
            • meas_astrom
            • meas_deblender
            • ip_diffim

            Parejkoj would you be able to take a quick look at these? The meas_modelfit is the only one with additional changes.

            tjenness Tim Jenness added a comment - More ready for review: pipe_tasks meas_astrom meas_deblender ip_diffim Parejkoj would you be able to take a quick look at these? The meas_modelfit is the only one with additional changes.
            Parejkoj John Parejko added a comment -

            Can you please assign them to someone else? I'm dealing with the monster (DM-20286).

            Parejkoj John Parejko added a comment - Can you please assign them to someone else? I'm dealing with the monster ( DM-20286 ).
            tjenness Tim Jenness added a comment -

            Parejkoj Of course. I asked whether you could look at them. "No" is an acceptable answer.

            tjenness Tim Jenness added a comment - Parejkoj Of course. I asked whether you could look at them. "No" is an acceptable answer.
            sullivan Ian Sullivan added a comment -

            I reviewed: meas_modelfit, ip_diffim, meas_deblender, and pipe_tasks.

            I can look at the remaining packages if needed.

            sullivan Ian Sullivan added a comment - I reviewed: meas_modelfit, ip_diffim, meas_deblender, and pipe_tasks. I can look at the remaining packages if needed.
            sullivan Ian Sullivan added a comment -

            I believe I have finished reviewing all of the packages. Please let me know if I've missed any.

            sullivan Ian Sullivan added a comment - I believe I have finished reviewing all of the packages. Please let me know if I've missed any.
            tjenness Tim Jenness added a comment -

            Thank you very much sullivan. You have reviewed all the open pull requests. There are now only a handful of packages remaining (including jointcal and obs_subaru).

            tjenness Tim Jenness added a comment - Thank you very much sullivan . You have reviewed all the open pull requests. There are now only a handful of packages remaining (including jointcal and obs_subaru).
            tjenness Tim Jenness added a comment -

            krughoff can you please review obs_sdss and obs_lsstSim changes. Mostly trivial although I fixed a couple of ResourceWarnings in obs_sdss.

            tjenness Tim Jenness added a comment - krughoff can you please review obs_sdss and obs_lsstSim changes. Mostly trivial although I fixed a couple of ResourceWarnings in obs_sdss.
            tjenness Tim Jenness added a comment -

            I'm going to mark this ticket as complete. It's about 98% complete. meas_mosaic has not been touched but that package is imminently disappearing. The remainder are a few example files and the odd bit of support code that don't stop tests failing. We will need to do a new check when we remove the afwGeom wrappers since we currently aren't preventing people adding new code with afwGeom usage in it.

            tjenness Tim Jenness added a comment - I'm going to mark this ticket as complete. It's about 98% complete. meas_mosaic has not been touched but that package is imminently disappearing. The remainder are a few example files and the odd bit of support code that don't stop tests failing. We will need to do a new check when we remove the afwGeom wrappers since we currently aren't preventing people adding new code with afwGeom usage in it.

            People

              tjenness Tim Jenness
              tjenness Tim Jenness
              Ian Sullivan, John Parejko
              Ian Sullivan, John Parejko, John Swinbank, Simon Krughoff (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.