Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20570

Pipeline failure treated as ap_verify success

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • ap_verify
    • None
    • 2
    • AP F19-3 (Skipped)
    • Alert Production

    Description

      scipipe/ap_verify build #286 was unable to run the full pipeline. However, this was counted as a successful build in Jenkins. It appears that, while ap_verify correctly generated metrics from the failed run, it did not return any error code to the shell. Fix this behavior so that failed processing runs can be detected by CI.

      Attachments

        Issue Links

          Activity

            Hi mrawls, could you please review this 23-line change? Thanks!

            krzys Krzysztof Findeisen added a comment - Hi mrawls , could you please review this 23-line change? Thanks!

            Thank you for fixing this! For the most part, your changes are clear, but I left a couple requests for clarification over on GitHub. Unless those lead to complicated additional changes, I think this is good to go.

            mrawls Meredith Rawls added a comment - Thank you for fixing this! For the most part, your changes are clear, but I left a couple requests for clarification over on GitHub. Unless those lead to complicated additional changes, I think this is good to go.

            People

              krzys Krzysztof Findeisen
              krzys Krzysztof Findeisen
              Meredith Rawls
              Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.