Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20585

Add meas_extensions_scarlet to lsst_distrib

    Details

      Description

      Implementation of RFC-606.

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            Hi Tim,
            Do you mind reviewing this ticket? All it does is add scarlet to lsst_distrib, per RFC-606, I just want to make sure this is all that needs to be done.

            Thanks,
            -Fred

            Show
            fred3m Fred Moolekamp added a comment - Hi Tim, Do you mind reviewing this ticket? All it does is add scarlet to lsst_distrib, per RFC-606 , I just want to make sure this is all that needs to be done. Thanks, -Fred
            Hide
            fred3m Fred Moolekamp added a comment -
            Show
            fred3m Fred Moolekamp added a comment - Jenkins build testing master for meas_extensions_scarlet : https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30178/pipeline
            Hide
            tjenness Tim Jenness added a comment -

            Looks okay and it is flake8 compliant. I'm not sure why there is an empty bin.src directory. You can remove it if it's not used.

            Please fix the 3 places where you use afwGeom.Point – they should use geom.

            I tried to build it locally but the test fails. Am I using an old Scarlet or something?

            Show
            tjenness Tim Jenness added a comment - Looks okay and it is flake8 compliant. I'm not sure why there is an empty bin.src directory. You can remove it if it's not used. Please fix the 3 places where you use afwGeom.Point – they should use geom. I tried to build it locally but the test fails. Am I using an old Scarlet or something?
            Hide
            fred3m Fred Moolekamp added a comment -

            Possibly. Both scarlet and meas_extensions_scarlet were updated today.

            Show
            fred3m Fred Moolekamp added a comment - Possibly. Both scarlet and meas_extensions_scarlet were updated today.

              People

              • Assignee:
                fred3m Fred Moolekamp
                Reporter:
                fred3m Fred Moolekamp
                Reviewers:
                Tim Jenness
                Watchers:
                Fred Moolekamp, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel