Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-207

Migrate Qserv czar code to the new logging system

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      DB_S14_06, DB_S14_07, DB_S14_08, DB_S14_9
    • Team:
      Data Access and Database

      Description

      This includes switching Qserv to the new logging. Fine-tuning (what messages are printed deciding on error level) is covered in DM-685.

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            K-T, log4j documentation indeed has that format code, but log4cxx does not mention it: http://logging.apache.org/log4cxx/apidocs/classlog4cxx_1_1_pattern_layout.html (formatting looks broken there)

            Show
            salnikov Andy Salnikov added a comment - K-T, log4j documentation indeed has that format code, but log4cxx does not mention it: http://logging.apache.org/log4cxx/apidocs/classlog4cxx_1_1_pattern_layout.html (formatting looks broken there)
            Hide
            ktl Kian-Tat Lim added a comment -

            The log4cxx documentation is (well) behind the code.

            Show
            ktl Kian-Tat Lim added a comment - The log4cxx documentation is (well) behind the code.
            Hide
            ktl Kian-Tat Lim added a comment -

            What is the intended interface for log_msg and newlog_msg? It seems a little strange to have them take a tuple rather than a list of arguments. (This would then have to be propagated up to inf, wrn, etc.)

            Show
            ktl Kian-Tat Lim added a comment - What is the intended interface for log_msg and newlog_msg ? It seems a little strange to have them take a tuple rather than a list of arguments. (This would then have to be propagated up to inf , wrn , etc.)
            Hide
            salnikov Andy Salnikov added a comment -

            I believe log_msg and newlog_msg are supposed to be implementation details, we should not expose them in the interface (add underscore to the names). And as I said above get rid of the logger completely once migration is done.

            Show
            salnikov Andy Salnikov added a comment - I believe log_msg and newlog_msg are supposed to be implementation details, we should not expose them in the interface (add underscore to the names). And as I said above get rid of the logger completely once migration is done.
            Hide
            salnikov Andy Salnikov added a comment -

            Looks OK after all changes.

            Show
            salnikov Andy Salnikov added a comment - Looks OK after all changes.

              People

              • Assignee:
                fritzm Fritz Mueller
                Reporter:
                fritzm Fritz Mueller
                Reviewers:
                Andy Salnikov
                Watchers:
                Andy Salnikov, Daniel Wang [X] (Inactive), Jacek Becla, Kian-Tat Lim, Serge Monkewitz
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Summary Panel