Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20742

Add "raw_header_wcs" datasetType to butler

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F19-1
    • Team:
      Alert Production

      Description

      To fully implement RFC-616, we need a way to get the original FITS WCS from a raw file. As proposed in that RFC, this will be a "raw_header_wcs" datasetType in the butler (gen2 and 3).

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment - - edited
            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run, now that I've rebased onto the merged DM-20154 : https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30322/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Nate Lust: can you please review this small change? The gen3 implementation isn't actually used anywhere, as I don't know how to register a new gen3 composite dataset type: if you can suggest how to get the new formatter.readRawHeaderWcs() method accessible to the gen3 butler, I would greatly appreciate it.

            Show
            Parejkoj John Parejko added a comment - Nate Lust : can you please review this small change? The gen3 implementation isn't actually used anywhere, as I don't know how to register a new gen3 composite dataset type: if you can suggest how to get the new formatter.readRawHeaderWcs() method accessible to the gen3 butler, I would greatly appreciate it.
            Hide
            nlust Nate Lust added a comment -

            Sorry it has taken so long to get to this, lots of travel and such. It all looks good to me.

            Show
            nlust Nate Lust added a comment - Sorry it has taken so long to get to this, lots of travel and such. It all looks good to me.
            Hide
            Parejkoj John Parejko added a comment - - edited

            New post-review rebasing jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30559/pipeline

            Nate Lust: did you have any ideas about how to get the functionality accessible to gen3? I've got a method implemented-formatter.readRawHeaderWcs-but I don't know how to tell gen3 to call that for the `raw_header_wcs` dataset type (or whatever the new name is).

            Show
            Parejkoj John Parejko added a comment - - edited New post-review rebasing jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30559/pipeline Nate Lust : did you have any ideas about how to get the functionality accessible to gen3? I've got a method implemented- formatter.readRawHeaderWcs -but I don't know how to tell gen3 to call that for the `raw_header_wcs` dataset type (or whatever the new name is).
            Hide
            nlust Nate Lust added a comment -

            I had a quick look, I should have time tomorrow to look in depth and give you an answer.

            Show
            nlust Nate Lust added a comment - I had a quick look, I should have time tomorrow to look in depth and give you an answer.
            Hide
            tjenness Tim Jenness added a comment - - edited

            I removed the daf_butler component from this ticket since this fix was entirely in obs_base. We will need another ticket to enable the gen3 change.

            Show
            tjenness Tim Jenness added a comment - - edited I removed the daf_butler component from this ticket since this fix was entirely in obs_base. We will need another ticket to enable the gen3 change.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Nate Lust
                Watchers:
                Jim Bosch, John Parejko, John Swinbank, Nate Lust, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel