Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20770

Unhelpful error message from PessimisticPatternMatcherB

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None

      Description

      The call PessimisticPatternMatcherB(ref_array[:, :3], self.log) in matchPessimisticB.py around line 387 generates the error message

      ValueError: negative dimensions are not allowed

      when ref_array is empty. Next time someone's in the code, could we improve the error message?  It happens when there are no possible matches from the reference catalogue.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          rhl Robert Lupton created issue -
          swinbank John Swinbank made changes -
          Field Original Value New Value
          Epic Link DM-19979 [ 307530 ]
          swinbank John Swinbank made changes -
          Story Points 1
          Team Alert Production [ 10300 ]
          swinbank John Swinbank made changes -
          Epic Link DM-19979 [ 307530 ] DM-21441 [ 423048 ]
          swinbank John Swinbank made changes -
          Epic Link DM-21441 [ 423048 ] DM-22484 [ 427311 ]
          swinbank John Swinbank made changes -
          Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
          swinbank John Swinbank made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          swinbank John Swinbank made changes -
          Assignee John Swinbank [ swinbank ]
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Hey Chris, do you have time for a tiny review?

          PR: https://github.com/lsst/meas_astrom/pull/136
          Jenkins: https://ci.lsst.codes/job/stack-os-matrix/32040/

          Show
          swinbank John Swinbank added a comment - Hey Chris, do you have time for a tiny review? PR: https://github.com/lsst/meas_astrom/pull/136 Jenkins: https://ci.lsst.codes/job/stack-os-matrix/32040/
          swinbank John Swinbank made changes -
          Reviewers Chris Morrison [ cmorrison ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          swinbank John Swinbank made changes -
          Epic Link DM-24339 [ 433026 ] DM-25139 [ 435257 ]
          cmorrison Chris Morrison [X] (Inactive) made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Re-Jenkins: https://ci.lsst.codes/job/stack-os-matrix/32100/

          Show
          swinbank John Swinbank added a comment - Re-Jenkins: https://ci.lsst.codes/job/stack-os-matrix/32100/
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Re-re-Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32102/

          Show
          swinbank John Swinbank added a comment - Re-re-Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32102/
          swinbank John Swinbank made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          Permalink
          swinbank John Swinbank added a comment -

          Thanks Chris!

          Show
          swinbank John Swinbank added a comment - Thanks Chris!

            People

            Assignee:
            swinbank John Swinbank
            Reporter:
            rhl Robert Lupton
            Reviewers:
            Chris Morrison [X] (Inactive)
            Watchers:
            Chris Morrison [X] (Inactive), John Swinbank, Robert Lupton
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.