Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:8
-
Epic Link:
-
Sprint:DRP F19-5
-
Team:Data Release Production
Description
Tanaka-san found a field in VVDS with bad stellar photometric matching to panstarrs. He found that compareWarp was clipping stars, despite the filter that rescues artifact candidates from the chopping block if they completely overlap a source detected in the PSF-Matched sigma-clipped template.
self.detect.nSigmaToGrow = 2
|
self.detectTemplate.nSigmaToGrow = 2.0
|
These current defaults assumed that footprints of the detections in the PSF-matched template are larger than those in the warps. Incorrect.
Fiddling with configs fixed the problem in the VVDS field: dataId=
{'tract': 10181, 'patch': '2,4', 'filter': 'HSC-G', 'visit': 82508}). I'm currently running a few configuration options through a full RC2 to determine with there are any unexpected side effects and metrics.
So far changing to detect.nSigmaToGrow = 1 looks promising.
Thanks for the reviews. I edited the commit to include the
self.detectTemplate.nSigmaToGrow = 2.4 with inline commit on why I'm restating a default, and kicked off a final Jenkins.