Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20800

GenericCamera - update Units and Descriptions

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Feb 1 - Feb 15, TSSW Sprint - Feb 15 - Mar 1
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The CSC XML design needs to be updated to include proper Units and attribute Descriptions.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. CAP-667 Catch-all for T&S tickets for ts_xml 8 (formerly 7.2)

          • Undefined - No priority assigned (may not apply or be unknown)
          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28939 Catch-all ticket for projects upgrade to ts_salobj 6.3

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment - - edited

            Also synchronize the xml with the latest schema used in the ATCamera and CCCamera.

            Show
            wvreeven Wouter van Reeven added a comment - - edited Also synchronize the xml with the latest schema used in the ATCamera and CCCamera.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            The comparison between the command XML files of the GenericCamera on the one side and ATCamera and CCCamera on the other side has yielded the following results:

            Commands existing on both sides:

            • takeImages

            Commands existing in GenericCamera only:

            • setROI
            • setFullFrame
            • startLiveView
            • stopLiveView

            The command items for takeImages in GenericCamera have been synchronized with those of ATCamera and CCCamera.

            Show
            wvreeven Wouter van Reeven added a comment - The comparison between the command XML files of the GenericCamera on the one side and ATCamera and CCCamera on the other side has yielded the following results: Commands existing on both sides: takeImages Commands existing in GenericCamera only: setROI setFullFrame startLiveView stopLiveView The command items for takeImages in GenericCamera have been synchronized with those of ATCamera and CCCamera.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment - - edited

            The GenericCamera Events that were synchronized with ATCamera and CCCamera are:

            • startShutterClose
            • startIntegration
            • startShutterOpen
            • startReadout
            • endReadout
            • endTakeImage
            • endShutterClose
            • endShutterOpen

            The Events that were added are:

            • endOfImageTelemetry
            • imageStored
            • fitsFilesWritten
            • fileCommandExecution
            • imageVisualization
            • offlineDetailedState
            • imageReadinessDetailedState
            • notReadyToTakeImage
            • calibrationDetailedState
            • shutterDetailedState
            • readyToTakeImage
            • ccsCommandState
            • prepareToTakeImage
            • ccsConfigured

            The Events not present in ATCamera and CCCamera but retained in GenericCamera are:

            • startTakeImage
            Show
            wvreeven Wouter van Reeven added a comment - - edited The GenericCamera Events that were synchronized with ATCamera and CCCamera are: startShutterClose startIntegration startShutterOpen startReadout endReadout endTakeImage endShutterClose endShutterOpen The Events that were added are: endOfImageTelemetry imageStored fitsFilesWritten fileCommandExecution imageVisualization offlineDetailedState imageReadinessDetailedState notReadyToTakeImage calibrationDetailedState shutterDetailedState readyToTakeImage ccsCommandState prepareToTakeImage ccsConfigured The Events not present in ATCamera and CCCamera but retained in GenericCamera are: startTakeImage
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            Tested the changes in the AllSky Docker container on my Raspberry Pi 4 using my Canon camera and it takes a picture when I command the CSC to do so.

            Show
            wvreeven Wouter van Reeven added a comment - Tested the changes in the AllSky Docker container on my Raspberry Pi 4 using my Canon camera and it takes a picture when I command the CSC to do so.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            ts_xml PR:

            https://github.com/lsst-ts/ts_xml/pull/413

            ts_GenericCamera PR:

            https://github.com/lsst-ts/ts_GenericCamera/pull/12

            The builds of ts_GenericCamera fail because ts_xml apparently isn't updated correctly or make_idl_files isn't run.

            Show
            wvreeven Wouter van Reeven added a comment - ts_xml PR: https://github.com/lsst-ts/ts_xml/pull/413 ts_GenericCamera PR: https://github.com/lsst-ts/ts_GenericCamera/pull/12 The builds of ts_GenericCamera fail because ts_xml apparently isn't updated correctly or make_idl_files isn't run.
            Hide
            Permalink
            tribeiro Tiago Ribeiro added a comment -

            Reviewed in GitHub.

            Show
            tribeiro Tiago Ribeiro added a comment - Reviewed in GitHub.

              People

              Assignee:
              wvreeven Wouter van Reeven
              Reporter:
              rbovill Rob Bovill
              Reviewers:
              Tiago Ribeiro
              Watchers:
              Rob Bovill, Tiago Ribeiro, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.