Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20841

Investigate reports of incorrect meas_mosaic WCSs after rotation by 90deg

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, meas_astrom
    • Labels:
    • Team:
      External

      Description

      Hisanori Furusawa and Sogo Mineo report that most of the WCSs produced by meas_mosaic in hscPipe 6.x (all of those that correspond to sensors with rotations relative to the focal plane) are incorrect - the SIP coefficients are dropped after rotation.  This is seen both in the headers and in the binary table.

      After a quick look at the code, I suspect this is only superficial, but still confusing: we rotate a WCS by prepending its mappings with a rotation using AST, which yields a WCS that cannot be represented as TAN-SIP without loss of precision.

      First piece of this ticket is to check that hypothesis.  The second (assuming the hypothesis holds) is to come up with a way to reduce that confusion.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          The new configs in the meas_base changes need to follow the new pattern adopted on DM-21308, but I trust you to do that and don't need to see this again if that's all you do in the next round of changes. Otherwise looks fine.

          Show
          jbosch Jim Bosch added a comment - The new configs in the meas_base changes need to follow the new pattern adopted on DM-21308 , but I trust you to do that and don't need to see this again if that's all you do in the next round of changes. Otherwise looks fine.
          Hide
          price Paul Price added a comment -

          Splitting off "Secure functionality of forcedPhotCcd, including proper use of refined astrometry, in conjunction with updating the calibrateCatalog and calibrateExposure" into its own ticket: DM-23352.

          Show
          price Paul Price added a comment - Splitting off "Secure functionality of forcedPhotCcd, including proper use of refined astrometry, in conjunction with updating the calibrateCatalog and calibrateExposure" into its own ticket: DM-23352 .
          Hide
          price Paul Price added a comment -

          Stripped this down to just the afw and some obs_subaru changes. In particular, everything in meas_base has moved to DM-23352.

          I'm going to run a final Jenkins, and then merge if it's green.

          Show
          price Paul Price added a comment - Stripped this down to just the afw and some obs_subaru changes. In particular, everything in meas_base has moved to DM-23352 . I'm going to run a final Jenkins, and then merge if it's green.
          Hide
          price Paul Price added a comment -
          Show
          price Paul Price added a comment - Jenkins is green .
          Hide
          price Paul Price added a comment -

          Merged to master.

          Show
          price Paul Price added a comment - Merged to master.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Parejko, Paul Price, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel