Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20892

Use proper temporary location to save environments

    XMLWordPrintable

    Details

    • Team:
      Architecture

      Description

      The rebuild script hard codes a path in /tmp for saving environments and does not clean up after itself. The script should switch to using mktemp to make a temporary location that will not collide with other users.

      The blocking problem currently is that no one can build a stack on lsst-dev because the hard coded path is only writeable by one user.

      This ticket should also implement the necessary logic to clean up the temporary location.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-18112 Update lsstsw in order to be able to deal with multiple environments

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment -

            Thank you for spotting the problem.

            I implemented the requested changes and made a couple of tests.

            I don't see the PR linked to the issue still, so I put the link here just in case: 

            https://github.com/lsst/lsstsw/pull/236

             

            Show
            gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - Thank you for spotting the problem. I implemented the requested changes and made a couple of tests. I don't see the PR linked to the issue still, so I put the link here just in case:  https://github.com/lsst/lsstsw/pull/236  
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks great. Thanks for the quick fix.

            Show
            tjenness Tim Jenness added a comment - Looks great. Thanks for the quick fix.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Tim Jenness do we need to make sure the script cleans up if it is interrupted during execution of that function?

            Show
            krughoff Simon Krughoff added a comment - Tim Jenness do we need to make sure the script cleans up if it is interrupted during execution of that function?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Probably yes but it's far less important now that each run gets its own temp files. I wouldn't delay merging for it.

            Show
            tjenness Tim Jenness added a comment - Probably yes but it's far less important now that each run gets its own temp files. I wouldn't delay merging for it.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            OK. Fair enough. Merge away.

            Show
            krughoff Simon Krughoff added a comment - OK. Fair enough. Merge away.

              People

              Assignee:
              gcomoretto Gabriele Comoretto [X] (Inactive)
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Tim Jenness
              Watchers:
              Gabriele Comoretto [X] (Inactive), Scott Daniel, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.