# Implement salobj to Kafka feeder

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
4
• Sprint:
TSSW Sprint - Aug 19 - Aug 31
• Team:
Telescope and Site

#### Description

Implement the salobj to Kafka feeder as designed in DM-20910, including documentation and unit tests.

#### Attachments

1. make_sal_data.py
0.4 kB

#### Activity

Hide
Russell Owen added a comment - - edited
Show
Russell Owen added a comment - - edited salobj pull request: https://github.com/lsst-ts/ts_salobj/pull/56 served documentation: https://ts-salkafka.lsst.io/v/DM-20911
Hide
Russell Owen added a comment - - edited

Jonathan Sick please review my use of Kafka, including in mocks and unit test. Note that I use a real serializer and test that it fails in test_kafka_info.py

Tiago Ribeiro please review the rest of the code, basically everything except the Kafka code (feel free to look at that, as well).

Also I beg one of you to please run the producer to make sure that I have not broken anything. I tried running from home using my usual standard commands:

 run_salkafka_producer.py Test --broker efd0.lsst.codes:9094 --registry https://registry-efd.lsst.codes/ & 

followed by

 python make_sal_data.py 

(I will attach the latter file to this ticket; it is not in the repo)
but the first command failed with:

 kafkit.registry.errors.RegistryBadRequestError: Registry error (409). 409 - Schema being registered is incompatible with an earlier schema 

Show
Russell Owen added a comment - - edited Jonathan Sick please review my use of Kafka, including in mocks and unit test. Note that I use a real serializer and test that it fails in test_kafka_info.py Tiago Ribeiro please review the rest of the code, basically everything except the Kafka code (feel free to look at that, as well). Also I beg one of you to please run the producer to make sure that I have not broken anything. I tried running from home using my usual standard commands: run_salkafka_producer.py Test --broker efd0.lsst.codes:9094 --registry https://registry-efd.lsst.codes/ & followed by python make_sal_data.py (I will attach the latter file to this ticket; it is not in the repo) but the first command failed with: kafkit.registry.errors.RegistryBadRequestError: Registry error (409). 409 - Schema being registered is incompatible with an earlier schema
Hide
Jonathan Sick added a comment -

This looks great from my perspective. I've got some comments on the PR at https://github.com/lsst-ts/ts_salkafka/pull/1

Show
Jonathan Sick added a comment - This looks great from my perspective. I've got some comments on the PR at https://github.com/lsst-ts/ts_salkafka/pull/1
Hide
Russell Owen added a comment -

Tiago approved it on github

Show
Russell Owen added a comment - Tiago approved it on github
Hide
Russell Owen added a comment -

Tiago added automatic checking and doc build.

Merged to develop and master and released as v1.0b1

Show
Russell Owen added a comment - Tiago added automatic checking and doc build. Merged to develop and master and released as v1.0b1

#### People

Assignee:
Russell Owen
Reporter:
Russell Owen
Reviewers:
Tiago Ribeiro
Watchers:
Angelo Fausti, Jonathan Sick, Russell Owen, Tiago Ribeiro