Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:0
-
Team:Telescope and Site
-
Urgent?:No
Description
Once the software is officially delivered to LSST, it will be necessary to update the design and code to conform to SAL constraints and conventions, as defined in https://confluence.lsstcorp.org/display/SYSENG/SAL+constraints+and+recommendations
This includes:
- Naming conventions
- Enumeration definition
- Implementation of all standard commands and events.
This task will be with DM-21699.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Risk Score | 0 |
| Assignee | Harini Sundararaman [ hsundararaman ] |
| Component/s | ts_main_telescope [ 16710 ] | |
| Component/s | WBS Rotator Control [ 14234 ] | |
| Key |
|
|
| Team | Telescope and Site [ 13500 ] | |
| Workflow | Telescope and Site Software workflow [ 173040 ] | Software Simplified Workflow for Project DM [ 401590 ] |
| Issue Type | Task [ 3 ] | Story [ 10001 ] |
| Priority | Critical [ 2 ] | |
| Project | Telescope and Site Software [ 10403 ] | Data Management [ 10501 ] |
| Status | Unplanned [ 1 ] | To Do [ 10001 ] |
| Assignee | Harini Sundararaman [X] [ hsundararaman ] | Te-Wei Tsai [ ttsai ] |
Hey Te-Wei - Can you please confirm this is done and send it to review? Thanks.
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Harini had done this already. I thought you had the related tests already. Please review this task. Thanks!
| Reviewers | Rob Bovill [ rbovill ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Harini started this process, but several Telemetry attributes still need to be updated:
Several failures occurred:
|
|
|
1) "CopleyStatusWordDrive does not conform to naming conventions."
|
|
|
2) "CopleyLatchingFaultStatus does not conform to naming conventions."
|
|
|
3) "Demand does not conform to naming conventions."
|
|
|
4) "Position does not conform to naming conventions."
|
|
|
5) "Error does not conform to naming conventions."
|
|
|
6) "Calibrated does not conform to naming conventions."
|
|
|
7) "Raw does not conform to naming conventions."
|
| Status | In Review [ 10004 ] | In Progress [ 3 ] |
I would like to make this change as part of DM-21699 if we can hold off until then. I was planning to implement that ticket after we are sure that we don't need the vendor's CSC code and can use my Rotator and Hexapod CSCs instead. We are planning to test the new Rotator CSC at SLAC on Monday 10/28. I beg you not to mess with the XML until then. I don't want any last-minute changes this close to a test.
| Description |
Once the software is officially delivered to LSST, it will be necessary to update the design and code to conform to SAL constraints and conventions, as defined in [https://confluence.lsstcorp.org/display/SYSENG/SAL+constraints+and+recommendations]
This includes: * Naming conventions * Enumeration definition * Implementation of all standard commands and events. |
Once the software is officially delivered to LSST, it will be necessary to update the design and code to conform to SAL constraints and conventions, as defined in [https://confluence.lsstcorp.org/display/SYSENG/SAL+constraints+and+recommendations]
This includes: * Naming conventions * Enumeration definition * Implementation of all standard commands and events. This task will be with [ |
| Assignee | Te-Wei Tsai [ ttsai ] | Russell Owen [ rowen ] |
| Status | In Progress [ 3 ] | To Do [ 10001 ] |
Most of this was implemented in DM-21699. However, we need to coordinate with Tekniker on updating the camera cable wrap controller because it is listening to the Rotator Application telemetry topic.
| Resolution | Done [ 10000 ] | |
| Status | To Do [ 10001 ] | Won't Fix [ 10405 ] |
| Resolution | Done [ 10000 ] | |
| Status | Won't Fix [ 10405 ] | To Do [ 10001 ] |
| Story Points | 0 | |
| Urgent? | off | |
| Labels | ts_rotator ts_xml |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Resolution | Done [ 10000 ] | |
| Status | In Progress [ 3 ] | Done [ 10002 ] |
The remaining problem was the Rotator Application topic and Wouter van Reeven fixed that for me when he renamed Rotator to MTRotator.
Note to QA: Once this task is complete, update robotframework_ts_xml/scripts/Attribute_Naming.py and robotframework_ts_xml/scripts/XML_Generic.py to remove the special handling for this CSC and regenerate the test suites.