Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20969

XML - Update Rotator XMLs to conform to Naming Conventions

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Once the software is officially delivered to LSST, it will be necessary to update the design and code to conform to SAL constraints and conventions, as defined in https://confluence.lsstcorp.org/display/SYSENG/SAL+constraints+and+recommendations

      This includes:

      • Naming conventions
      • Enumeration definition
      • Implementation of all standard commands and events.

      This task will be with DM-21699.

        Attachments

          Issue Links

            Activity

            Hide
            rbovill Rob Bovill added a comment -

            Note to QA: Once this task is complete, update robotframework_ts_xml/scripts/Attribute_Naming.py and robotframework_ts_xml/scripts/XML_Generic.py to remove the special handling for this CSC and regenerate the test suites.

            Show
            rbovill Rob Bovill added a comment - Note to QA: Once this task is complete, update robotframework_ts_xml/scripts/Attribute_Naming.py and robotframework_ts_xml/scripts/XML_Generic.py to remove the special handling for this CSC and regenerate the test suites.
            Hide
            aclements Andy Clements added a comment -

            Hey Te-Wei - Can you please confirm this is done and send it to review?  Thanks.

            Show
            aclements Andy Clements added a comment - Hey Te-Wei - Can you please confirm this is done and send it to review?  Thanks.
            Hide
            ttsai Te-Wei Tsai added a comment -

            Harini had done this already. I thought you had the related tests already. Please review this task. Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Harini had done this already. I thought you had the related tests already. Please review this task. Thanks!
            Hide
            rbovill Rob Bovill added a comment -

            Harini started this process, but several Telemetry attributes still need to be updated:

            Several failures occurred:
             
            1) "CopleyStatusWordDrive does not conform to naming conventions."
             
            2) "CopleyLatchingFaultStatus does not conform to naming conventions."
             
            3) "Demand does not conform to naming conventions."
             
            4) "Position does not conform to naming conventions."
             
            5) "Error does not conform to naming conventions."
             
            6) "Calibrated does not conform to naming conventions."
             
            7) "Raw does not conform to naming conventions." 

             

            Show
            rbovill Rob Bovill added a comment - Harini started this process, but several Telemetry attributes still need to be updated: Several failures occurred:   1) "CopleyStatusWordDrive does not conform to naming conventions."   2) "CopleyLatchingFaultStatus does not conform to naming conventions."   3) "Demand does not conform to naming conventions."   4) "Position does not conform to naming conventions."   5) "Error does not conform to naming conventions."   6) "Calibrated does not conform to naming conventions."   7) "Raw does not conform to naming conventions."  
            Hide
            rowen Russell Owen added a comment -

            I would like to make this change as part of DM-21699 if we can hold off until then. I was planning to implement that ticket after we are sure that we don't need the vendor's CSC code and can use my Rotator and Hexapod CSCs instead. We are planning to test the new Rotator CSC at SLAC on Monday 10/28. I beg you not to mess with the XML until then. I don't want any last-minute changes this close to a test.

            Show
            rowen Russell Owen added a comment - I would like to make this change as part of  DM-21699 if we can hold off until then. I was planning to implement that ticket after we are sure that we don't need the vendor's CSC code and can use my Rotator and Hexapod CSCs instead. We are planning to test the new Rotator CSC at SLAC on Monday 10/28. I beg you not to mess with the XML until then. I don't want any last-minute changes this close to a test.
            Hide
            rowen Russell Owen added a comment - - edited

            Most of this was implemented in DM-21699. However, we need to coordinate with Tekniker on updating the camera cable wrap controller because it is listening to the Rotator Application telemetry topic.

            Show
            rowen Russell Owen added a comment - - edited Most of this was implemented in DM-21699 . However, we need to coordinate with Tekniker on updating the camera cable wrap controller because it is listening to the Rotator Application telemetry topic.
            Hide
            rowen Russell Owen added a comment -

            The remaining problem was the Rotator Application topic and Wouter van Reeven fixed that for me when he renamed Rotator to MTRotator.

            Show
            rowen Russell Owen added a comment - The remaining problem was the Rotator Application topic and Wouter van Reeven fixed that for me when he renamed Rotator to MTRotator.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rbovill Rob Bovill
              Reviewers:
              Rob Bovill
              Watchers:
              Andy Clements, Rob Bovill, Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.