Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-20978

Stub out base lsstimport and move lsstcppimport import to afw

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, base
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Arch 2019-08-19
    • Team:
      Architecture

      Description

      After some investigation by Colin Slater we have learned that the lsst/__init__.py files do not need to import lsstimport from the base package. The library loader flags are no longer relevant for our pybind11 packages.

      Furthermore we have learned that the lsstcppimport is required but is only required by some packages that are using afw C++ interfaces.

      We therefore propose the following:

      1. Replace lsstimport.py with an empty stub file that does nothing.
      2. Force afw to import lsstcppimport.

      In a later ticket we will remove the lsst/__init__.py files from all the LSST python packages. Once that is done lsstimport.py can be removed from base package.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Jim Bosch Changing base and tweaking afw fixes the problem. Can you please take a look?

            Show
            tjenness Tim Jenness added a comment - Jim Bosch Changing base and tweaking afw fixes the problem. Can you please take a look?
            Hide
            jbosch Jim Bosch added a comment -

            Looks fine, but it's worth noting that the only reason lsstcppimport is where it is (instead of in a normal package namespace like lsst.base.cppimport) was so lsstimport could import it safely in all of the places it was imported.  Might be worth moving it now.

            Show
            jbosch Jim Bosch added a comment - Looks fine, but it's worth noting that the only reason lsstcppimport is where it is (instead of in a normal package namespace like lsst.base.cppimport ) was so lsstimport could import it safely in all of the places it was imported.  Might be worth moving it now.
            Hide
            tjenness Tim Jenness added a comment -

            I've moved it to lsst.base.cppimport and will merge once Jenkins passes.

            Show
            tjenness Tim Jenness added a comment - I've moved it to lsst.base.cppimport and will merge once Jenkins passes.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Jim Bosch
              Watchers:
              Colin Slater, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.