Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21016

Handle DECam instrument signature data in gen3

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Epic Link:
    • Sprint:
      AP F19-6 (November), AP S20-1 (December), AP S20-2 (January), AP S20-3 (February), AP S20-4 (March)
    • Team:
      Alert Production

      Description

      DM-20763 dealt with ingesting DECam data, but punted on managing the instrument signature data. This will require at-minimum implementing writeCuratedCalibrations.

      I've linked a variety of DECam calibration-related tickets as "related', since we can maybe close some of those as won't fix once this is done (since they might be gen2-specific).

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21915 Support Gen 3 ingestion of ap_verify datasets

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21155 Implement QE curve interface as described in RFC-625

          • Done
          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21862 Extend Gen3 butler support for obs_decam

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20763 Add initial support for Gen3 Butler to obs_decam

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22794 obs_base tests should not use daf_butler test configs

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-22370 Support Gen 3 ingestion of image-type calibs

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-23230 Make writeCuratedCalibrations returns the DatasetRefs it wrote

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7286 Please test ingesting DECam raw data and calibration data

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-23976 Move gen3 generic curated calibrations ingest code to obs_base

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-23980 Standardize Gen3 instrument class names and location

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17538 Generate stack-produced (rather than CP) calibration products for DECam

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7287 Please test obs_decam with the LSST-produced calibration data

          • Invalid

          Improvement - An improvement or enhancement to an existing feature or task. DM-6495 Please add raw data and calibration data to validation_data_decam

          • To Do

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            DM-23976 has implemented writeCuratedCalibrations for obs_decam, so defects and camera are now taken care of. DM-23980 took care of removing the `gen3` bit from the module hierarchies. The other cleanups and renames on this ticket are probably not worth trying to sort out in what would likely be an ugly rebase, and many of them depend on the not yet finished plan for how calibrations will be handled in general.

            I will close the four PRs on this ticket, and am marking the ticket as "done" because at least defects are now being managed per the ticket description.

            Show
            Parejkoj John Parejko added a comment - DM-23976 has implemented writeCuratedCalibrations for obs_decam, so defects and camera are now taken care of. DM-23980 took care of removing the `gen3` bit from the module hierarchies. The other cleanups and renames on this ticket are probably not worth trying to sort out in what would likely be an ugly rebase, and many of them depend on the not yet finished plan for how calibrations will be handled in general. I will close the four PRs on this ticket, and am marking the ticket as "done" because at least defects are now being managed per the ticket description.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Should we close this as either `Invalid` or `Done`, given DM-23976?

            Show
            Parejkoj John Parejko added a comment - Should we close this as either `Invalid` or `Done`, given DM-23976 ?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            DM-23980 has been created for the instrument class renames.

            Show
            tjenness Tim Jenness added a comment - DM-23980 has been created for the instrument class renames.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I think I will put renaming of instrument classes (removal of gen3) onto a new ticket since it doesn't affect any of the other discussions. I absolutely agree that now is the time to change names and class paths.

            Show
            tjenness Tim Jenness added a comment - I think I will put renaming of instrument classes (removal of gen3) onto a new ticket since it doesn't affect any of the other discussions. I absolutely agree that now is the time to change names and class paths.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            From a pure EV perspective, yes, if this work is being handed off from AP to Architecture, let's do that by writing a brief summary of what happened on this ticket, marking it as done, and then using another ticket for Arch activities. (It's not obvious from the description here whether that other ticket is DM-23976, but I have no horse in that race.)

            Show
            swinbank John Swinbank added a comment - From a pure EV perspective, yes, if this work is being handed off from AP to Architecture, let's do that by writing a brief summary of what happened on this ticket, marking it as done, and then using another ticket for Arch activities. (It's not obvious from the description here whether that other ticket is DM-23976 , but I have no horse in that race.)
            7 older comments

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Christopher Waters, Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.