# Handle DECam instrument signature data in gen3

XMLWordPrintable

#### Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
8
• Sprint:
AP F19-6 (November), AP S20-1 (December), AP S20-2 (January), AP S20-3 (February), AP S20-4 (March)
• Team:

#### Description

DM-20763 dealt with ingesting DECam data, but punted on managing the instrument signature data. This will require at-minimum implementing writeCuratedCalibrations.

I've linked a variety of DECam calibration-related tickets as "related', since we can maybe close some of those as won't fix once this is done (since they might be gen2-specific).

#### Activity

Hide
John Swinbank added a comment -

From a pure EV perspective, yes, if this work is being handed off from AP to Architecture, let's do that by writing a brief summary of what happened on this ticket, marking it as done, and then using another ticket for Arch activities. (It's not obvious from the description here whether that other ticket is DM-23976, but I have no horse in that race.)

Show
John Swinbank added a comment - From a pure EV perspective, yes, if this work is being handed off from AP to Architecture, let's do that by writing a brief summary of what happened on this ticket, marking it as done, and then using another ticket for Arch activities. (It's not obvious from the description here whether that other ticket is DM-23976 , but I have no horse in that race.)
Hide
Tim Jenness added a comment -

I think I will put renaming of instrument classes (removal of gen3) onto a new ticket since it doesn't affect any of the other discussions. I absolutely agree that now is the time to change names and class paths.

Show
Tim Jenness added a comment - I think I will put renaming of instrument classes (removal of gen3) onto a new ticket since it doesn't affect any of the other discussions. I absolutely agree that now is the time to change names and class paths.
Hide
Tim Jenness added a comment -

DM-23980 has been created for the instrument class renames.

Show
Tim Jenness added a comment - DM-23980 has been created for the instrument class renames.
Hide
John Parejko added a comment -

Should we close this as either Invalid or Done, given DM-23976?

Show
John Parejko added a comment - Should we close this as either Invalid or Done, given DM-23976 ?
Hide
John Parejko added a comment -

DM-23976 has implemented writeCuratedCalibrations for obs_decam, so defects and camera are now taken care of. DM-23980 took care of removing the gen3 bit from the module hierarchies. The other cleanups and renames on this ticket are probably not worth trying to sort out in what would likely be an ugly rebase, and many of them depend on the not yet finished plan for how calibrations will be handled in general.

I will close the four PRs on this ticket, and am marking the ticket as "done" because at least defects are now being managed per the ticket description.

Show
John Parejko added a comment - DM-23976 has implemented writeCuratedCalibrations for obs_decam, so defects and camera are now taken care of. DM-23980 took care of removing the gen3 bit from the module hierarchies. The other cleanups and renames on this ticket are probably not worth trying to sort out in what would likely be an ugly rebase, and many of them depend on the not yet finished plan for how calibrations will be handled in general. I will close the four PRs on this ticket, and am marking the ticket as "done" because at least defects are now being managed per the ticket description.

#### People

Assignee:
John Parejko
Reporter:
John Parejko
Watchers:
Christopher Waters, Eric Bellm, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Simon Krughoff, Tim Jenness