Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21047

Update ATMCS Simulator to conform to new XML changes

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None

      Description

      DM-20732 (soon to be merged) changes the XML to publish new values (essentially forwarded from the ATPng CSC) and publishes telemetry as arrays. The simulator needs to be updated to reflect this functionality.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20732 Modify ATMCS Telemetry XML to use arrays to provide high-speed telemetry from drives and encoders

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            This required a bit of work because the telemetry topics now are arrays. I added an update_telemetry method to the CSC and a separate loop method that calls update_events at 10Hz (as before) and update_telemetry every 10 times through the loop.

            I also took the liberty of removing tests for task.done() before canceling the task, since cancel is allowed (and is a no-op) if the task is already done.

            Pull request: https://github.com/lsst-ts/ts_ATMCSSimulator/pull/10

            Show
            rowen Russell Owen added a comment - This required a bit of work because the telemetry topics now are arrays. I added an update_telemetry method to the CSC and a separate loop method that calls update_events at 10Hz (as before) and update_telemetry every 10 times through the loop. I also took the liberty of removing tests for task.done() before canceling the task, since cancel is allowed (and is a no-op) if the task is already done. Pull request: https://github.com/lsst-ts/ts_ATMCSSimulator/pull/10
            Hide
            Permalink
            ecoughlin Eric Coughlin added a comment -

            Reviewed in github, looks good to me.

            Show
            ecoughlin Eric Coughlin added a comment - Reviewed in github, looks good to me.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Merged to develop and master and tagged v0.7.0

            Show
            rowen Russell Owen added a comment - Merged to develop and master and tagged v0.7.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              pingraham Patrick Ingraham
              Reviewers:
              Eric Coughlin
              Watchers:
              Eric Coughlin, Patrick Ingraham, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.