Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21065

Replace pexConfig.makePolicy with pexConfig.makePropertySet

    Details

    • Story Points:
      4
    • Sprint:
      Arch 2019-08-19, Arch 2019-08-26
    • Team:
      Architecture

      Description

      We are trying to remove usage of pex_policy but there are still some places where it is used. Some of these come from pexConfig.makePolicy. Analyzing the code it looks like it would be fairly straightforward to replace those with calls to pexConfig.makePropertySet.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            The changes to meas_algorithms and pipe_tasks were trivial. The change to ip_diffim was significantly larger and resulted in changes to numerous files. This has resulted in Policy being removed from the package completely apart from in the deprecation wrapper.

            Show
            tjenness Tim Jenness added a comment - The changes to meas_algorithms and pipe_tasks were trivial. The change to ip_diffim was significantly larger and resulted in changes to numerous files. This has resulted in Policy being removed from the package completely apart from in the deprecation wrapper.
            Hide
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim please can you take a look. There are a couple of outstanding questions:

            1. Should I move the policy deprecation to utils or somewhere since I could use it in meas_algorithms.
            2. You mentioned copying out the parts we need from the PropertySet rather than copying the entire PropertySet but do we want that subtle change in behavior where every value will be required even if before it was allowed to be missing depending on other values?

            I do still need to add the deprecation statement in pex_config makePolicy.

            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim please can you take a look. There are a couple of outstanding questions: Should I move the policy deprecation to utils or somewhere since I could use it in meas_algorithms. You mentioned copying out the parts we need from the PropertySet rather than copying the entire PropertySet but do we want that subtle change in behavior where every value will be required even if before it was allowed to be missing depending on other values? I do still need to add the deprecation statement in pex_config makePolicy.
            Hide
            ktl Kian-Tat Lim added a comment -

            We decided not to put a pex_policy dependency into utils, and that copying out PropertySet items into a custom config class would be excessive.

            Show
            ktl Kian-Tat Lim added a comment - We decided not to put a pex_policy dependency into utils, and that copying out PropertySet items into a custom config class would be excessive.
            Hide
            ktl Kian-Tat Lim added a comment -

            Minor comments in ip_diffim.  Looks good.

            Show
            ktl Kian-Tat Lim added a comment - Minor comments in ip_diffim.  Looks good.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Kian-Tat Lim, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel