Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21103

lsst.verify seems to be broken

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: verify
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      Arch 2019-08-26
    • Team:
      Architecture

      Description

      If you unpack the attached tarball and run test_load_metrics.py, you will find that it works on w.2019.29 but not on w.2019.33.  test_load_metrics.py just tries to load a MetricsSet from a local directory.  The commissioning team was planning to use this sort of interface in building its test notebooks.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            This was initially fixed in DM-10401 but when utils was reorganized in DM-10384 it broke again because it seemed like the import of pex_exceptions was spurious. I've re-added the import with a note. The problem with testing is that it's essentially impossible to test the code without importing pex_exceptions to check that you got the right exception (and pytest pre-imports everything – so the tests were working at the moment because a completely different test file had imported pex_exceptions).

            Show
            tjenness Tim Jenness added a comment - This was initially fixed in DM-10401 but when utils was reorganized in DM-10384 it broke again because it seemed like the import of pex_exceptions was spurious. I've re-added the import with a note. The problem with testing is that it's essentially impossible to test the code without importing pex_exceptions to check that you got the right exception (and pytest pre-imports everything – so the tests were working at the moment because a completely different test file had imported pex_exceptions).
            Hide
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim I think the utils fix is sufficient and the verify PR can be closed.

            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim I think the utils fix is sufficient and the verify PR can be closed.
            Hide
            danielsf Scott Daniel added a comment -

            Thanks everyone for converging so quickly on the fix.

            Show
            danielsf Scott Daniel added a comment - Thanks everyone for converging so quickly on the fix.
            Hide
            ktl Kian-Tat Lim added a comment -

            The fix looks reasonable to me.

            Show
            ktl Kian-Tat Lim added a comment - The fix looks reasonable to me.
            Hide
            tjenness Tim Jenness added a comment -

            Merged the utils change. Jenkins passed.

            Show
            tjenness Tim Jenness added a comment - Merged the utils change. Jenkins passed.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                danielsf Scott Daniel
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Brian Van Klaveren, Jonathan Sick, Kian-Tat Lim, Krzysztof Findeisen, Scott Daniel, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel