Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21130

Please add asynctest to Docker images

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_auxiliary_telescope
    • Labels:
      None

      Description

      Please add the https://github.com/Martiusweb/asynctest package to Docker containers used for Python T&S software. This adds some useful support to unittest, including the ability to write asynchronous test cases directly, e.g.:

      async def test_foo(self):
          # code
      

      instead of

      def test_foo(self):
          async def doit(self):
              # code
       
          asyncio.get_event_loop().run_until_complete(doit())
      

      (which silently does nothing if one forgets the event loop call)

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            For my own testing I've pip installed asynctest, and have been using it to write tests for the spectrograph. I quite like it so far (although I may not actually need the mocking functionality right now after all).

            Show
            Parejkoj John Parejko added a comment - For my own testing I've pip installed asynctest, and have been using it to write tests for the spectrograph. I quite like it so far (although I may not actually need the mocking functionality right now after all).
            Hide
            tribeiro Tiago Ribeiro added a comment -

            Work done as part of DM-21161

            Show
            tribeiro Tiago Ribeiro added a comment - Work done as part of DM-21161
            Hide
            Parejkoj John Parejko added a comment -

            Shouldn't this be marked "Done" instead of "Won't Fix" since you did it as part of another ticket?

            Show
            Parejkoj John Parejko added a comment - Shouldn't this be marked "Done" instead of "Won't Fix" since you did it as part of another ticket?
            Hide
            rowen Russell Owen added a comment -

            Interesting question. I think it depends if the story point credits are wanted or not. But I'm not sure and would like to know.

            Show
            rowen Russell Owen added a comment - Interesting question. I think it depends if the story point credits are wanted or not. But I'm not sure and would like to know.
            Hide
            Parejkoj John Parejko added a comment - - edited

            I saw "won't fix" and my brain said "wait, didn't he say he did this, and wasn't Russell already using it? Did they undo that?"

            Show
            Parejkoj John Parejko added a comment - - edited I saw "won't fix" and my brain said "wait, didn't he say he did this, and wasn't Russell already using it? Did they undo that?"

              People

              Assignee:
              tribeiro Tiago Ribeiro
              Reporter:
              rowen Russell Owen
              Watchers:
              John Parejko, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.