Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21153

Fix bugs in DcrAssembleCoaddTask from PipelineTask merge

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F19-2
    • Team:
      Alert Production

      Description

      The merge of DM-20692 changed the call signature of AssembleCoaddTask.processResults(), which is used in DcrAssembleCoaddTask.  The breaking change was not caught by existing unit tests.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20781 Reprocess HiTS data using DCR mitigation

          • Done
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20692 Convert PipelineTasks to new api

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-21202 Add option to correct for DCR in coadd PSF calculation

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Pull request is here: https://github.com/lsst/pipe_tasks/pull/309

            Show
            sullivan Ian Sullivan added a comment - Pull request is here:  https://github.com/lsst/pipe_tasks/pull/309
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            This is hopefully straightforward, and I have verified that it fixes the problem introduced by the PipelineTask merge last week.

            Show
            sullivan Ian Sullivan added a comment - This is hopefully straightforward, and I have verified that it fixes the problem introduced by the PipelineTask merge last week.
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            Looks fine. I think Robert raises a fair larger philosophical point in the PR, but as you say, this ticket is just to bring the existing DCR functionality so that it works with the changed coda API. Image discontinuities which affect measuring PSFs on coadds, which DCR must do somehow, is a worthy topic of discussion outside this bugfix.

            Show
            mrawls Meredith Rawls added a comment - Looks fine. I think Robert raises a fair larger philosophical point in the PR, but as you say, this ticket is just to bring the existing DCR functionality so that it works with the changed coda API. Image discontinuities which affect measuring PSFs on coadds, which DCR must do somehow, is a worthy topic of discussion outside this bugfix.

              People

              Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Meredith Rawls
              Watchers:
              Ian Sullivan, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.