Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21153

Fix bugs in DcrAssembleCoaddTask from PipelineTask merge

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      AP F19-2
    • Team:
      Alert Production

      Description

      The merge of DM-20692 changed the call signature of AssembleCoaddTask.processResults(), which is used in DcrAssembleCoaddTask.  The breaking change was not caught by existing unit tests.

        Attachments

          Issue Links

            Activity

            Hide
            sullivan Ian Sullivan added a comment -
            Show
            sullivan Ian Sullivan added a comment - Pull request is here:  https://github.com/lsst/pipe_tasks/pull/309
            Hide
            sullivan Ian Sullivan added a comment -

            This is hopefully straightforward, and I have verified that it fixes the problem introduced by the PipelineTask merge last week.

            Show
            sullivan Ian Sullivan added a comment - This is hopefully straightforward, and I have verified that it fixes the problem introduced by the PipelineTask merge last week.
            Hide
            mrawls Meredith Rawls added a comment -

            Looks fine. I think Robert raises a fair larger philosophical point in the PR, but as you say, this ticket is just to bring the existing DCR functionality so that it works with the changed coda API. Image discontinuities which affect measuring PSFs on coadds, which DCR must do somehow, is a worthy topic of discussion outside this bugfix.

            Show
            mrawls Meredith Rawls added a comment - Looks fine. I think Robert raises a fair larger philosophical point in the PR, but as you say, this ticket is just to bring the existing DCR functionality so that it works with the changed coda API. Image discontinuities which affect measuring PSFs on coadds, which DCR must do somehow, is a worthy topic of discussion outside this bugfix.

              People

              • Assignee:
                sullivan Ian Sullivan
                Reporter:
                sullivan Ian Sullivan
                Reviewers:
                Meredith Rawls
                Watchers:
                Ian Sullivan, Meredith Rawls
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel