Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21155

Implement QE curve interface as described in RFC-625

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None

      Description

      Since RFC-625 is now adopted, this issue is to implement the design outlined there. Specifically, this will define an on disk representation for QE curves including a butler dataset for retrieving them. It will also require implementing a free function for evaluating the curves at various points in wavelength and position on the detector.

        Attachments

          Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DM-21016 Handle DECam instrument signature data in gen3

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-625 Support QE curves in obs_lsst

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            There are actually 5 branches with associated pull request for this: obs_base, obs_lsst, obs_lsst_data, meas_algorithms, and pipe_tasks.

            I believe I have a system that will work with tests. If you get to a point where it's clear we diverge on design sense, let me know and we can assess.

            Show
            krughoff Simon Krughoff added a comment - There are actually 5 branches with associated pull request for this: obs_base, obs_lsst, obs_lsst_data, meas_algorithms, and pipe_tasks. I believe I have a system that will work with tests. If you get to a point where it's clear we diverge on design sense, let me know and we can assess.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Sorry for the delay. I have some comments on GitHub.

            Show
            tjenness Tim Jenness added a comment - Sorry for the delay. I have some comments on GitHub.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            I looked at obs_decam#123 and ap_verify#77, as requested on Slack. Changes look good, and I can't think of any other places where we refer to the defect ingestion task.

            Show
            krzys Krzysztof Findeisen added a comment - I looked at obs_decam#123 and ap_verify#77 , as requested on Slack. Changes look good, and I can't think of any other places where we refer to the defect ingestion task.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Merged.

            Show
            krughoff Simon Krughoff added a comment - Merged.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Tim Jenness
              Watchers:
              Bo Xin [X] (Inactive), John Parejko, Krzysztof Findeisen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.