Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21166

Create DiaCalculation plugins that replicate current ap_association behavior.

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_association
    • Labels:
      None
    • Story Points:
      10
    • Sprint:
      AP F19-4 (2H September), AP F19-5 (October)
    • Team:
      Alert Production

      Description

      Currently, several static and time-series features are implemented in ap_association. This ticket will replicate the behavior and values calculated in the current code within the DiaCalculation framework created by DM-18494.

        Attachments

          Issue Links

            Activity

            Show
            cmorrison Chris Morrison added a comment - One last Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30597/pipeline/49/
            Hide
            sophiereed Sophie Reed added a comment -

            Refactoring the fail method makes it a lot tider, thanks.

            Show
            sophiereed Sophie Reed added a comment - Refactoring the fail method makes it a lot tider, thanks.
            Hide
            cmorrison Chris Morrison added a comment -

            Not every plugin will produce columns in the same format as seen in most of the flux summary plugins. For instance, the plugin for the mean RA/DEC outputs columns of "ra" and "decl" and doesn't take a filterName in it's input. This will also be true of other filter independent plugins. It might make sense to have a inheritable plugin for the flux calculations specifically, but that might be one to many inherited classes.

            Any suggestions?

            Show
            cmorrison Chris Morrison added a comment - Not every plugin will produce columns in the same format as seen in most of the flux summary plugins. For instance, the plugin for the mean RA/DEC outputs columns of "ra" and "decl" and doesn't take a filterName in it's input. This will also be true of other filter independent plugins. It might make sense to have a inheritable plugin for the flux calculations specifically, but that might be one to many inherited classes. Any suggestions?
            Hide
            sophiereed Sophie Reed added a comment -

            I've looked at it all and it seems like there is a lot of code duplication. Is it possible to reuse code more frequently? It seems that the fail functions in particular are all basically identical and there could be just one that takes the name as a variable.

            I've made a few minor comments on gitHub, some of them are only made once but apply to all the other implementations of that line of code. 

            Show
            sophiereed Sophie Reed added a comment - I've looked at it all and it seems like there is a lot of code duplication. Is it possible to reuse code more frequently? It seems that the fail functions in particular are all basically identical and there could be just one that takes the name as a variable. I've made a few minor comments on gitHub, some of them are only made once but apply to all the other implementations of that line of code. 
            Show
            cmorrison Chris Morrison added a comment - Jenkins:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30568/pipeline
            Hide
            cmorrison Chris Morrison added a comment - - edited

            The list of plugins to create, as currently defined in the _set_flux_stats function in ap_association:

            • PSFluxMean - Done
            • PSFluxMeanErr - Done
            • PSFluxSigma - Done
            • PSFluxChi2 - Done
            • PSFluxNdata - Done
            • PSFluxPercentiles - Done
            • PSFluxMAD - Done
            • PSFluxSkew - Done
            • PSFluxMin/Max - Done
            • PSFluxMaxSlope - Done
            • PSFluxLinearFit - Done
            • PSFluxStetsonJ - Done
            • PSFluxErrMean - Done

            In addition, these measurements need to be created for TOTFlux:

            • TOTFluxMean - Done
            • TOTFluxMeanErr - Done
            • TOTFluxSigma - Done
            Show
            cmorrison Chris Morrison added a comment - - edited The list of plugins to create, as currently defined in the _set_flux_stats function in ap_association: PSFluxMean - Done PSFluxMeanErr - Done PSFluxSigma - Done PSFluxChi2 - Done PSFluxNdata - Done PSFluxPercentiles - Done PSFluxMAD - Done PSFluxSkew - Done PSFluxMin/Max - Done PSFluxMaxSlope - Done PSFluxLinearFit - Done PSFluxStetsonJ - Done PSFluxErrMean - Done In addition, these measurements need to be created for TOTFlux: TOTFluxMean - Done TOTFluxMeanErr - Done TOTFluxSigma - Done

              People

              • Assignee:
                cmorrison Chris Morrison
                Reporter:
                cmorrison Chris Morrison
                Reviewers:
                Sophie Reed
                Watchers:
                Chris Morrison, Eric Bellm, John Swinbank, Sophie Reed
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel