Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21241

Fix setting of boresight rotation angle for imsim data

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      DRP F19-2, DRP F19-4
    • Team:
      Data Release Production

      Description

      For individual obs packages, we are using "translators" to convert metadata from raw files into internally consistent conventions (as many telescopes have different sets of conventions and header naming).  Our convention for boresight rotation angle is:

      At boresightRotAngle = 0, the focal plane pixels are aligned:
      +x: E->W (-ve RA), +y: S->N (+ve Dec)
      

      (and see the documentation).

      Accordingly, the imsim translator in obs_lsst should reflect that:

      boresightRotAngle = 90 deg - ROTANGLE
      

      (where the ROTANGLE is the FITS card in the raw data).

      The reason data is currently being processed properly is due to a compensation (prior to the translator functionality) for this 90 deg shift in the lsstCamMapper here. This latter "correction" should be removed from there and accommodated in the imsim translator.

      This change will be validated by running a visit of DC2 data before and after and checking that we get consistent results.

        Attachments

          Activity

          lauren Lauren MacArthur created issue -
          lauren Lauren MacArthur made changes -
          Field Original Value New Value
          Epic Link DM-20164 [ 323028 ]
          lauren Lauren MacArthur made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          lauren Lauren MacArthur made changes -
          Summary Fit setting of boresight rotation angle for imsim data Fix setting of boresight rotation angle for imsim data
          yusra Yusra AlSayyad made changes -
          Epic Link DM-20164 [ 323028 ] DM-21252 [ 414682 ]
          yusra Yusra AlSayyad made changes -
          Sprint DRP F19-2 [ 939 ] DRP F19-2, DRP F19-4 [ 939, 955 ]
          lauren Lauren MacArthur made changes -
          Description For individual obs packages, we are using "translators" to convert metadata from raw files into internally consistent conventions (as many telescopes have different sets of conventions and header naming).  Our convention for boresight rotation angle is:
          {code:python}
          At boresightRotAngle = 0, the focal plane pixels are alligned:
          +x: E->W (-ve RA), +y: S->N (+ve Dec)
          {code}
          (and see the [documentation|http://doxygen.lsst.codes/stack/doxygen/x_masterDoxyDoc/namespacelsst_1_1afw_1_1image.html#a7ea6a783e80a6f548b3fb535f0bd9fb7]).

          Accordingly, the {{imsim}} translator in {{obs_lsst}} should reflect that:
          {code:python}
          boresightRotAngle = 90 deg - ROTANGLE
          {code}
          (where the ROTANGLE is the FITS card in the raw data).

          The reason data is currently being processed properly is due to a compensation (prior to the translator functionality) for this 90 deg shift in the {{lsstCamMapper}}[here|https://github.com/lsst/obs_lsst/blob/master/python/lsst/obs/lsst/lsstCamMapper.py#L164-L166]. This latter "correction" should be removed from there and accommodated in the {{imsim}} translator.

          This change will be validated by running a visit of DC2 data before and after and checking that we get consistent results.
          For individual obs packages, we are using "translators" to convert metadata from raw files into internally consistent conventions (as many telescopes have different sets of conventions and header naming).  Our convention for boresight rotation angle is:
          {code:python}
          At boresightRotAngle = 0, the focal plane pixels are alligned:
          +x: E->W (-ve RA), +y: S->N (+ve Dec)
          {code}
          (and see the [documentation|http://doxygen.lsst.codes/stack/doxygen/x_masterDoxyDoc/namespacelsst_1_1afw_1_1image.html#a7ea6a783e80a6f548b3fb535f0bd9fb7]).

          Accordingly, the {{imsim}} translator in {{obs_lsst}} should reflect that:
          {code:python}
          boresightRotAngle = 90 deg - ROTANGLE
          {code}
          (where the ROTANGLE is the FITS card in the raw data).

          The reason data is currently being processed properly is due to a compensation (prior to the translator functionality) for this 90 deg shift in the {{lsstCamMapper}} [here|https://github.com/lsst/obs_lsst/blob/master/python/lsst/obs/lsst/lsstCamMapper.py#L164-L166]. This latter "correction" should be removed from there and accommodated in the {{imsim}} translator.

          This change will be validated by running a visit of DC2 data before and after and checking that we get consistent results.
          lauren Lauren MacArthur made changes -
          lauren Lauren MacArthur made changes -
          lauren Lauren MacArthur made changes -
          lauren Lauren MacArthur made changes -
          lauren Lauren MacArthur made changes -
          Reviewers Tim Jenness [ tjenness ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          tjenness Tim Jenness made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          lauren Lauren MacArthur made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          lauren Lauren MacArthur made changes -
          Description For individual obs packages, we are using "translators" to convert metadata from raw files into internally consistent conventions (as many telescopes have different sets of conventions and header naming).  Our convention for boresight rotation angle is:
          {code:python}
          At boresightRotAngle = 0, the focal plane pixels are alligned:
          +x: E->W (-ve RA), +y: S->N (+ve Dec)
          {code}
          (and see the [documentation|http://doxygen.lsst.codes/stack/doxygen/x_masterDoxyDoc/namespacelsst_1_1afw_1_1image.html#a7ea6a783e80a6f548b3fb535f0bd9fb7]).

          Accordingly, the {{imsim}} translator in {{obs_lsst}} should reflect that:
          {code:python}
          boresightRotAngle = 90 deg - ROTANGLE
          {code}
          (where the ROTANGLE is the FITS card in the raw data).

          The reason data is currently being processed properly is due to a compensation (prior to the translator functionality) for this 90 deg shift in the {{lsstCamMapper}} [here|https://github.com/lsst/obs_lsst/blob/master/python/lsst/obs/lsst/lsstCamMapper.py#L164-L166]. This latter "correction" should be removed from there and accommodated in the {{imsim}} translator.

          This change will be validated by running a visit of DC2 data before and after and checking that we get consistent results.
          For individual obs packages, we are using "translators" to convert metadata from raw files into internally consistent conventions (as many telescopes have different sets of conventions and header naming).  Our convention for boresight rotation angle is:
          {code:python}
          At boresightRotAngle = 0, the focal plane pixels are aligned:
          +x: E->W (-ve RA), +y: S->N (+ve Dec)
          {code}
          (and see the [documentation|http://doxygen.lsst.codes/stack/doxygen/x_masterDoxyDoc/namespacelsst_1_1afw_1_1image.html#a7ea6a783e80a6f548b3fb535f0bd9fb7]).

          Accordingly, the {{imsim}} translator in {{obs_lsst}} should reflect that:
          {code:python}
          boresightRotAngle = 90 deg - ROTANGLE
          {code}
          (where the ROTANGLE is the FITS card in the raw data).

          The reason data is currently being processed properly is due to a compensation (prior to the translator functionality) for this 90 deg shift in the {{lsstCamMapper}} [here|https://github.com/lsst/obs_lsst/blob/master/python/lsst/obs/lsst/lsstCamMapper.py#L164-L166]. This latter "correction" should be removed from there and accommodated in the {{imsim}} translator.

          This change will be validated by running a visit of DC2 data before and after and checking that we get consistent results.

            People

            Assignee:
            lauren Lauren MacArthur
            Reporter:
            lauren Lauren MacArthur
            Reviewers:
            Tim Jenness
            Watchers:
            Eli Rykoff, James Chiang, John Parejko, Lauren MacArthur, Robert Lupton, Simon Krughoff, Tim Jenness, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.