Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21247

Allow specifying checkpoints and log level when queuing a script

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      2
    • Sprint:
      TSSW Sprint - Sep 16 - Sep 28
    • Team:
      Telescope and Site

      Description

      At present setting and modifying log level and checkpoints for a script requires sending commands to the script while it is running. This is not very practical, especially for the script queue. Allow specifying log level and checkpoints as part of the Script's configure command and the ScriptQueue's add command.

      The existing setLogLevel and setCheckpoints Script command will continue to work, but are deprecated.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            Changes:

            • Add fields logLevel, pauseCheckpoint and stopCheckpoint to the ScriptQueue add command and the Script configure command in ts_xml.
            • Support the new fields in ts_salobj BaseScript.do_configure. Add tests.
            • Support the new fields ts_scriptqueue ScriptQueue and ScriptInfo. Add tests.

            Note: the ts_salobj work is based off of the pending salobj 5/SAL 4. The XML can be merged whenever it passes review, but the rest will have to wait.

            Pull requests:

            Also this overview which I wrote for INRIA might be of some interest: https://confluence.lsstcorp.org/display/LTS/Supporting+Script+Checkpoints+and+Log+Levels+in+LOVE

            Show
            rowen Russell Owen added a comment - - edited Changes: Add fields logLevel , pauseCheckpoint and stopCheckpoint to the ScriptQueue add command and the Script configure command in ts_xml. Support the new fields in ts_salobj BaseScript.do_configure. Add tests. Support the new fields ts_scriptqueue ScriptQueue and ScriptInfo. Add tests. Note: the ts_salobj work is based off of the pending salobj 5/SAL 4. The XML can be merged whenever it passes review, but the rest will have to wait. Pull requests: ts_xml: https://github.com/lsst-ts/ts_xml/pull/136 ts_salobj: https://github.com/lsst-ts/ts_salobj/pull/60 ts_scriptqueue: https://github.com/lsst-ts/ts_scriptqueue/pull/38 Also this overview which I wrote for INRIA might be of some interest: https://confluence.lsstcorp.org/display/LTS/Supporting+Script+Checkpoints+and+Log+Levels+in+LOVE
            Hide
            rowen Russell Owen added a comment - - edited

            John Parejko please review the ts_salobj and ts_scriptqueue pull requests. Rob Bovill has kindly reviewed the ts_xml changes (despite being on route to La Serena).

            I did not update run_one_script nor the request ui to support these new features. I filed DM-21362 to do that work. An open question is whether I should implement those features on this ticket branch. But if I'm going to do that then I want to merge DM-21331 first to avoid merge conflicts.

            Show
            rowen Russell Owen added a comment - - edited John Parejko please review the ts_salobj and ts_scriptqueue pull requests. Rob Bovill has kindly reviewed the ts_xml changes (despite being on route to La Serena). I did not update run_one_script nor the request ui to support these new features. I filed DM-21362 to do that work. An open question is whether I should implement those features on this ticket branch. But if I'm going to do that then I want to merge DM-21331 first to avoid merge conflicts.
            Hide
            rowen Russell Owen added a comment -

            Another ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/141

            Show
            rowen Russell Owen added a comment - Another ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/141
            Hide
            Parejkoj John Parejko added a comment -

            Thank you for the updates: I think this will make more sense to someone coming into it fresh.

            Show
            Parejkoj John Parejko added a comment - Thank you for the updates: I think this will make more sense to someone coming into it fresh.
            Hide
            rowen Russell Owen added a comment - - edited

            All pull requests merged to develop.

            New releases will be done using DM-21366

            Show
            rowen Russell Owen added a comment - - edited All pull requests merged to develop. New releases will be done using DM-21366

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              John Parejko
              Watchers:
              John Parejko, Rob Bovill, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.