Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21248

cameraMapper _standardizeExposure should not try to create a WCS for each amp

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None

      Description

      After DM-20154, updates were made to _standardizeExposure which now creates a WCS from visit metadata. The problem is that _standardizeExposure is called per amp when reading raws, which leads to a cascade of warnings with obs_lsst because there are a lot of amps, and the visitInfo hasn't been created yet with the appropriate metadata to create a WCS. However, even if the warnings aren't there, it is unnecessary and inefficient to create a WCS for each amp, when this should be done once at the ccd-level after assembly (and after the appropriate metadata has been created).

      I believe this should be a quick fix that simply checks if it is called with the amp level before trying to set the wcs. At the same time maybe the per-amp setting of the filter is also unnecessary?

        Attachments

          Issue Links

            Activity

            Hide
            erykoff Eli Rykoff added a comment -

            By the way, this does not address the issue that the stack may try (and fail) to create a wcs for calibration frames (biases, darks, flats) that should not have a wcs. But at least this should cut down the number of warnings by a factor of the number of amps!

            Show
            erykoff Eli Rykoff added a comment - By the way, this does not address the issue that the stack may try (and fail) to create a wcs for calibration frames (biases, darks, flats) that should not have a wcs. But at least this should cut down the number of warnings by a factor of the number of amps!
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            I'm told that Gen3 will have a concept of whether an exposure was taken on-sky, making this possible to handle (where as at the moment, without quite a bit of work to push the necessary information around, it is not).

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I'm told that Gen3 will have a concept of whether an exposure was taken on-sky, making this possible to handle (where as at the moment, without quite a bit of work to push the necessary information around, it is not).
            Hide
            tjenness Tim Jenness added a comment -

            I've made a quick patch to obs_base for this.

            Show
            tjenness Tim Jenness added a comment - I've made a quick patch to obs_base for this.
            Hide
            erykoff Eli Rykoff added a comment -

            Tim Jenness You want me to review?

            Show
            erykoff Eli Rykoff added a comment - Tim Jenness You want me to review?
            Hide
            tjenness Tim Jenness added a comment -

            Eli Rykoff would you please review? I have a Jenkins run going just in case I broke everything.

            Show
            tjenness Tim Jenness added a comment - Eli Rykoff would you please review? I have a Jenkins run going just in case I broke everything.
            Hide
            erykoff Eli Rykoff added a comment -

            Looks good to me.

            Show
            erykoff Eli Rykoff added a comment - Looks good to me.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Eli Rykoff
              Watchers:
              Colin Slater, Eli Rykoff, John Parejko, Lauren MacArthur, Merlin Fisher-Levine, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.