Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Science Pipelines DM-W15-5, Science Pipelines DM-S15-1
-
Team:Data Release Production
Description
When building meas_base, or any other measurement plugins which follow the same interface, with clang, I see a bunch of warnings along the lines of:
In file included from src/ApertureFlux.cc:34:
|
include/lsst/meas/base/ApertureFlux.h:197:18: warning: 'lsst::meas::base::ApertureFluxAlgorithm::measure' hides overloaded virtual function
|
[-Woverloaded-virtual]
|
virtual void measure(
|
^
|
include/lsst/meas/base/Algorithm.h:183:18: note: hidden overloaded virtual function 'lsst::meas::base::SimpleAlgorithm::measure' declared here:
|
different number of parameters (4 vs 2)
|
virtual void measure(
|
This is an artefact of a workaround for SWIG issues; the warnings aren't indicative of a fundamental problem, but if we can avoid them we should.
While we're at it, we should also fix:
include/lsst/meas/base/ApertureFlux.h:233:1: warning: 'ApertureFluxResult' defined as a struct here but previously declared as a class
|
[-Wmismatched-tags]
|
struct ApertureFluxResult : public FluxResult {
|
^
|
include/lsst/meas/base/ApertureFlux.h:65:1: note: did you mean struct here?
|
class ApertureFluxResult;
|
^~~~~
|
struct
|
Attachments
Issue Links
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Watchers | John Swinbank [ John Swinbank ] | Jim Bosch, John Swinbank [ Jim Bosch, John Swinbank ] |
Watchers | Jim Bosch, John Swinbank [ Jim Bosch, John Swinbank ] | Jim Bosch, John Swinbank, Lauren MacArthur, Perry Gee [ Jim Bosch, John Swinbank, Lauren MacArthur, Perry Gee ] |
Story Points | 1 |
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Reviewers | Lauren MacArthur [ lauren ] | |
Status | In Progress [ 3 ] | In Review [ 10004 ] |
Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Reviewers | Lauren MacArthur [ lauren ] | Jim Bosch [ jbosch ] |
Status | Reviewed [ 10101 ] | In Review [ 10004 ] |
Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Sprint | Science Pipelines DM-W15-5 [ 129 ] | Science Pipelines DM-W15-5, Science Pipelines DM-S15-1 [ 129, 140 ] |
Rank | Ranked higher |
Resolution | Done [ 10000 ] | |
Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Component/s | meas_base [ 10750 ] |