Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2131

Resolve compiler warnings in new measurement framework

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      When building meas_base, or any other measurement plugins which follow the same interface, with clang, I see a bunch of warnings along the lines of:

      In file included from src/ApertureFlux.cc:34:
      include/lsst/meas/base/ApertureFlux.h:197:18: warning: 'lsst::meas::base::ApertureFluxAlgorithm::measure' hides overloaded virtual function
            [-Woverloaded-virtual]
          virtual void measure(
                       ^
      include/lsst/meas/base/Algorithm.h:183:18: note: hidden overloaded virtual function 'lsst::meas::base::SimpleAlgorithm::measure' declared here:
            different number of parameters (4 vs 2)
          virtual void measure(

      This is an artefact of a workaround for SWIG issues; the warnings aren't indicative of a fundamental problem, but if we can avoid them we should.

      While we're at it, we should also fix:

      include/lsst/meas/base/ApertureFlux.h:233:1: warning: 'ApertureFluxResult' defined as a struct here but previously declared as a class
            [-Wmismatched-tags]
      struct ApertureFluxResult : public FluxResult {
      ^
      include/lsst/meas/base/ApertureFlux.h:65:1: note: did you mean struct here?
      class ApertureFluxResult;
      ^~~~~
      struct

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, John Swinbank, Lauren MacArthur, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.