Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21333

Implement afw.image.Filter replacement(s)

    XMLWordPrintable

    Details

      Description

      Implement the filter class design put forth in RFC-624 or RFC-730, whichever takes precedence.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-27169 Use FilterLabel in Exposure/ExposureInfo

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-624 Replace afw.image.Filter with global-free label-only classes

          • Retired

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-730 Replace afw.image.Filter with simple label-based classes

          • Implemented
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-25746 filterName in APDB needs to be one of g, r, i, z, or y

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-27246 Lots of Doxygen warnings in afw

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-27247 Use py::kw_only in FilterLabel constructor in pybind11 version 2.6

          • To Do
          links to

          Web Link Python Example Gist

          Web Link RFC-730 Example

          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            I ran into a problem related to this when trying to have Butlers for two different cameras in the same notebook. The error was

            `RuntimeError: afw Filters were already defined on [insert long list of FilterDefinitions here]`

            In sum, I was told "don't do that" as well as "here is one workaround but it's dangerous to go around resetting filters willy-nilly" and "this ticket should address the issue." Thus, I am documenting my problem here instead of opening a new ticket.

            Instructions to reproduce: https://lsstc.slack.com/archives/C3UCAEW3D/p1584386101034300 

            Temporary workaround to reset filters: https://lsstc.slack.com/archives/C3UCAEW3D/p1584386779038000 

            Show
            mrawls Meredith Rawls added a comment - I ran into a problem related to this when trying to have Butlers for two different cameras in the same notebook. The error was `RuntimeError: afw Filters were already defined on [insert long list of FilterDefinitions here] ` In sum, I was told "don't do that" as well as "here is one workaround but it's dangerous to go around resetting filters willy-nilly" and "this ticket should address the issue." Thus, I am documenting my problem here instead of opening a new ticket. Instructions to reproduce: https://lsstc.slack.com/archives/C3UCAEW3D/p1584386101034300   Temporary workaround to reset filters: https://lsstc.slack.com/archives/C3UCAEW3D/p1584386779038000  
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            John Swinbank has there been any progress on finding someone who can work on this longstanding problem? As gen2 deprecation approaches and people consider using LATISS and BOT data or BOT and ImSim or Hsc or whatever in the same python process we are going to run into this more and more. Resetting filters allows things to function but it leaves people wide open to getting the wrong filter because they forgot to run reset.

            Show
            tjenness Tim Jenness added a comment - John Swinbank has there been any progress on finding someone who can work on this longstanding problem? As gen2 deprecation approaches and people consider using LATISS and BOT data or BOT and ImSim or Hsc or whatever in the same python process we are going to run into this more and more. Resetting filters allows things to function but it leaves people wide open to getting the wrong filter because they forgot to run reset.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            As an additional note, in DM-26119 I learned that when you use pipetask in multiprocessing mode you never get the filters defined because there is no Instrument object instantiated. In single process mode it works fine because at some point pipetask does need to create an Instrument.

            Show
            tjenness Tim Jenness added a comment - As an additional note, in DM-26119 I learned that when you use pipetask in multiprocessing mode you never get the filters defined because there is no Instrument object instantiated. In single process mode it works fine because at some point pipetask does need to create an Instrument .
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Looks good, few comments on PR.

             

            Show
            salnikov Andy Salnikov added a comment - Looks good, few comments on PR.  

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen, Meredith Rawls, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.