Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21370

Improve DeferredDatasetHandle interface so we can access dataId

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Excerpt from pipe_tasks' assemble.py

              if isinstance(tempExpRefList[0], DeferredDatasetHandle):
                  dataIds = [ref.datasetRefOrType.dataId for ref in tempExpRefList]
                  psfMatchedDataIds = [ref.datasetRefOrType.dataId for ref in supplementaryData.warpRefList]
              else:
                  dataIds = [ref.dataId for ref in tempExpRefList]
                  psfMatchedDataIds = [ref.dataId for ref in supplementaryData.warpRefList]
      

      Quote from Jim Bosch in a code review:

      It's a shame the deferred handle object exposes datasetRefOrType as as public attribute - that's really an implementation detail (in that it's just saving all of the arguments to butler.put directly). It looks like we should be doing some normalization of the those arguments up-front so it can just have a ref attribute directly.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            I've done this work on DM-21246; closing as invalid.

            Show
            jbosch Jim Bosch added a comment - I've done this work on DM-21246 ; closing as invalid.

              People

              • Assignee:
                Unassigned
                Reporter:
                yusra Yusra AlSayyad
                Watchers:
                Jim Bosch, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel