Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ap_verify
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:AP F19-4 (2H September)
-
Team:Alert Production
Description
As described on Community, the reference catalog configs recently chagned to require that users specify both Gen 2- and Gen 3-style configs. This change breaks the configs shipped with ap_verify datasets, which only have Gen 2 style configs:
Traceback (most recent call last):
|
File "lsstsw3/stack/Linux64/ap_verify/18.1.0-5-g1dd6499+4/bin/ap_verify.py", line 29, in <module>
|
result = runApVerify()
|
File "lsstsw3/stack/Linux64/ap_verify/18.1.0-5-g1dd6499+4/python/lsst/ap/verify/ap_verify.py", line 161, in runApVerify
|
apPipeResults = runApPipe(workspace, args)
|
File "lsstsw3/stack/Linux64/ap_verify/18.1.0-5-g1dd6499+4/python/lsst/ap/verify/pipeline_driver.py", line 75, in runApPipe
|
makePpdb(configArgs)
|
File "lsstsw3/stack/Linux64/ap_pipe/18.1.0-4-gcd8f52c+5/python/lsst/ap/pipe/make_ppdb.py", line 108, in makePpdb
|
parsedCmd = parser.parse_args(args=args)
|
File "lsstsw3/stack/Linux64/ap_pipe/18.1.0-4-gcd8f52c+5/python/lsst/ap/pipe/make_ppdb.py", line 84, in parse_args
|
namespace.config.validate()
|
File "lsstsw3/stack/Linux64/ap_pipe/18.1.0-4-gcd8f52c+5/python/lsst/ap/pipe/ap_pipe.py", line 100, in validate
|
pexConfig.Config.validate(self)
|
File "lsstsw3/stack/Linux64/pex_config/18.1.0-5-gc286bb7+1/python/lsst/pex/config/config.py", line 1234, in validate
|
field.validate(self)
|
File "lsstsw3/stack/Linux64/pex_config/18.1.0-5-gc286bb7+1/python/lsst/pex/config/configurableField.py", line 340, in validate
|
value.validate()
|
File "lsstsw3/stack/Linux64/pex_config/18.1.0-5-gc286bb7+1/python/lsst/pex/config/config.py", line 1234, in validate
|
field.validate(self)
|
File "lsstsw3/stack/Linux64/pex_config/18.1.0-5-gc286bb7+1/python/lsst/pex/config/configurableField.py", line 340, in validate
|
value.validate()
|
File "lsstsw3/stack/Linux64/pipe_tasks/18.1.0-19-g9e516c23/python/lsst/pipe/tasks/calibrate.py", line 294, in validate
|
f"Gen2 ({astromRefCatGen2}) and Gen3 ({self.connections.astromRefCat}) astrometry reference "
|
ValueError: Gen2 (gaia) and Gen3 (ps1_pv3_3pi_20170110) astrometry reference catalogs are different. These options must be kept in sync until Gen2 is retired.
|
Update the configs for ap_verify_ci_hits2015 and ap_verify_hits2015 so that ap_verify runs again.
Attachments
Issue Links
- relates to
-
DM-17023 Refactor the Dimensions and query system
- Done
Activity
Looks good, thanks for catching this and fixing it so promptly.
I'm assuming you ran ap_verify with this change to confirm it does indeed fix the problem.
Good call to preserve the old config setting with the new value for now. If `refObjLoader`s are fully deprecated in the future (which I agree isn't on the immediate horizon per Jim's comment on the Community post), we will need to revisit this, because I'm pretty sure trying to define a non-existent config causes a runtime error.
Actually, per the Community post, we're required to define both config fields. There was no call for me to make. Thanks for the review, though!
Krzysztof Findeisen
added a comment - - edited Actually, per the Community post, we're required to define both config fields. There was no call for me to make. Thanks for the review, though! 
Hi Meredith Rawls, can you review this 12-line change? Thanks!