Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21422

Fix ip_diffim mosaic debug plots broken by Mosaic.makeMosaic signature change and compiler warning

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, ip_diffim
    • Labels:
      None

      Description

      The frame= arg has been removed from afwDisplay.Mosaic.makeMosaic.

      Robert Lupton 17:30

      Use

      disp = afwDisplay.Display(frame)
      mos.makeMosaic(display=disp, title="Kernel Basis Images")

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-21525 Compiler warning about catching polymorphic exceptions by value

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            gkovacs Gabor Kovacs [X] (Inactive) created issue -
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Field Original Value New Value
            Assignee Gabor Kovacs [ gkovacs ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Description The {{frame=}} arg has been removed from {{afwDisplay.Mosaic.makeMosaic}}.
            		The {{frame=}} arg has been removed from {{afwDisplay.Mosaic.makeMosaic}}.

            {quote}Robert Lupton 17:30

            Use

            disp = afwDisplay.Display(frame)
            mos.makeMosaic(display=disp, title="Kernel Basis Images")
            {quote}
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Link This issue relates to DM-21525 [ DM-21525 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Story Points 1 2
            Hide
            Permalink
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            Also contains a trivial fix of gcc-8 compiler warning (DM-21525) in afw/math/Statistics.h:115.

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - Also contains a trivial fix of gcc-8 compiler warning ( DM-21525 ) in afw/math/Statistics.h:115 .
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Component/s afw [ 10714 ]
            Component/s ip_diffim [ 10743 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Summary Fix ip_diffim mosaic debug plots broken by Mosaic.makeMosaic signature change Fix ip_diffim mosaic debug plots broken by Mosaic.makeMosaic signature change and compiler warning
            Hide
            Permalink
            gkovacs Gabor Kovacs [X] (Inactive) added a comment -

            Would you please review this issue?

             

            Please note there are 2 PRs in this ticket:

            https://github.com/lsst/ip_diffim/pull/136

            https://github.com/lsst/afw/pull/489

             

            Show
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - Would you please review this issue?   Please note there are 2 PRs in this ticket: https://github.com/lsst/ip_diffim/pull/136 https://github.com/lsst/afw/pull/489  
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks okay. I broke it originally when I removed the deprecated API but there weren't any tests for it so sorry about that.

            Show
            tjenness Tim Jenness added a comment - Looks okay. I broke it originally when I removed the deprecated API but there weren't any tests for it so sorry about that.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            swinbank John Swinbank made changes -
            Epic Link DM-21441 [ 423048 ]
            swinbank John Swinbank made changes -
            Team Alert Production [ 10300 ]
            gkovacs Gabor Kovacs [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              gkovacs Gabor Kovacs [X] (Inactive)
              Reporter:
              gkovacs Gabor Kovacs [X] (Inactive)
              Reviewers:
              Tim Jenness
              Watchers:
              Gabor Kovacs [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.