Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-21470

insertFakes.py is broken

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      Recent infrastructure work broke insertFakes.py (see, for instance, the misspelled import statement at line 35

      https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/insertFakes.py#L35

      This happened silently, because there are no unit tests that exercise this code.

      This ticket is to fix the parts of the code that have been broken and then add a unit test so that the code cannot break silently again.

        Attachments

          Activity

          Hide
          danielsf Scott Daniel added a comment -

          It is worth noting that, in order to actually run the code in insertFakes.py, I'm going to have to make pipe_tasks depend on galsim.  I imagine some people will have opinions about that.

          Show
          danielsf Scott Daniel added a comment - It is worth noting that, in order to actually run the code in insertFakes.py , I'm going to have to make pipe_tasks depend on galsim .  I imagine some people will have opinions about that.
          Hide
          swinbank John Swinbank added a comment -

          Obvious breakages have been fixed on other tickets. Let's come back to this when we find some new, less-obvious, ones...

          Show
          swinbank John Swinbank added a comment - Obvious breakages have been fixed on other tickets. Let's come back to this when we find some new, less-obvious, ones...

            People

            Assignee:
            danielsf Scott Daniel
            Reporter:
            danielsf Scott Daniel
            Watchers:
            John Swinbank, Scott Daniel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: